← 返回首页
gh-107954: Fix configuration type for the perf profiler by pablogsal · Pull Request #124636 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

gh-107954: Fix configuration type for the perf profiler#124636

Merged
ambv merged 3 commits into
python:mainfrom
pablogsal:perf-fix
Sep 27, 2024
Merged

gh-107954: Fix configuration type for the perf profiler#124636
ambv merged 3 commits into
python:mainfrom
pablogsal:perf-fix

Conversation

pablogsal commented Sep 26, 2024 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

bedevere-app Bot mentioned this pull request Sep 26, 2024
Closed
pablogsal mentioned this pull request Sep 26, 2024
Merged
pablogsal requested a review from ambv September 26, 2024 22:07

diegorusso commented Sep 26, 2024

Copy link
Copy Markdown
Contributor

@pablogsal thanks! I confirm that this PR fixes #124613

diegorusso commented Sep 26, 2024

Copy link
Copy Markdown
Contributor

Tests are failing, I think they need to be updated as well.

====================================================================== FAIL: test_config_get (test.test_capi.test_config.CAPITests.test_config_get) (name='perf_profiling', option_type=<class 'bool'>, sys_attr=None) ---------------------------------------------------------------------- Traceback (most recent call last): File "/Users/admin/actions-runner/_work/cpython/cpython/Lib/test/test_capi/test_config.py", line 130, in test_config_get self.assertIsInstance(value, option_type) ~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^ AssertionError: 0 is not an instance of <class 'bool'>

vstinner commented Sep 27, 2024

Copy link
Copy Markdown
Member

@pablogsal: I pushed a change in your PR to update tests.

vstinner commented Sep 27, 2024

Copy link
Copy Markdown
Member

I didn't know that perf_profiling can have two values, 1 or 2. It's not documented.

@pablogsal: I also pushed a change to complete the doc and add more tests. Would you mind to review my change?

vstinner mentioned this pull request Sep 27, 2024
Closed

diegorusso commented Sep 27, 2024

Copy link
Copy Markdown
Contributor

Thanks folks, I've tested the PR in our internal CI and all the tests are passing. LGTM.

ambv merged commit 02b49c5 into python:main Sep 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
ambv Awaiting requested review from ambv

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Footer

© 2026 GitHub, Inc.