← 返回首页
gh-97850: remove ``find_loader`` and ``get_loader`` from ``pkgutil`` by picnixz · Pull Request #119656 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
Resetting focus

gh-97850: remove find_loader and get_loader from pkgutil#119656

Merged
hugovk merged 17 commits into
python:mainfrom
picnixz:remove-deprecated-pkgutil
Nov 1, 2024
Merged

gh-97850: remove find_loader and get_loader from pkgutil#119656
hugovk merged 17 commits into
python:mainfrom
picnixz:remove-deprecated-pkgutil

Conversation

picnixz commented May 28, 2024
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

picnixz changed the title Remove find_loader and get_loader from pkgutil gh-#97850: remove find_loader and get_loader from pkgutil May 28, 2024
picnixz changed the title gh-#97850: remove find_loader and get_loader from pkgutil gh-97850: remove find_loader and get_loader from pkgutil May 28, 2024
picnixz changed the title gh-97850: remove find_loader and get_loader from pkgutil [3.14] gh-97850: remove find_loader and get_loader from pkgutil May 28, 2024

picnixz commented May 28, 2024

Copy link
Copy Markdown
Member Author

Quick question but how do you manage the whatsnews sections when a feature is being removed? I cannot really change it to :func:`!pkgutil.find_loader` since these are available in previous versions.

picnixz changed the title [3.14] gh-97850: remove find_loader and get_loader from pkgutil gh-97850: remove find_loader and get_loader from pkgutil May 28, 2024

sobolevn left a comment
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

Please, update

:func:`pkgutil.find_loader` :func:`pkgutil.get_loader`

to be

:func:`!pkgutil.find_loader` :func:`!pkgutil.get_loader`

Since all python versions have their own versions of 3.13.rst / 3.12.rst / etc.

bedevere-app Bot commented May 29, 2024

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

picnixz commented May 29, 2024

Copy link
Copy Markdown
Member Author

Yes, that's what I was actually asking. Should I just suppress every possible links in the others 3.x.rst files even though they exist? (if so, I can do it but I wanted to be sure that all references should be suppressed even for old versions for which the reference would exist).

Copy link
Copy Markdown
Member

Again, older versions won't be affected, because they live in their own branches. And we won't backport this change.

picnixz commented May 29, 2024

Copy link
Copy Markdown
Member Author

Oh yes, it was dumb of me. I incorrectly assumed that the 3.12 page was for the corresponding branch (seems I'm still not entirely awake). Anyway, I have made the requested changes; please review again.

bedevere-app Bot commented May 29, 2024

Copy link
Copy Markdown

Thanks for making the requested changes!

@sobolevn: please review the changes made to this pull request.

bedevere-app Bot requested a review from sobolevn May 29, 2024 08:17

sobolevn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

Sorry, I somehow did not send this comment.

Comment thread Lib/test/test_doctest/test_doctest.py Outdated Show resolved Hide resolved
sobolevn requested a review from brettcannon May 29, 2024 14:27
10 hidden items Load more…
Comment thread Doc/whatsnew/3.13.rst Outdated Show resolved Hide resolved
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>

hugovk commented Aug 2, 2024

Copy link
Copy Markdown
Member

This has a conflict after the #122085 re-org.

picnixz commented Aug 2, 2024

Copy link
Copy Markdown
Member Author

Oh, I forgot about this one :') I'll fix the conflicts err... I don't know when (I'm a bit busy writing something currently and don't know if I'll have tomorrow)

hugovk commented Aug 2, 2024

Copy link
Copy Markdown
Member

Thanks, absolutely no rush with this :)

Copy link
Copy Markdown
Contributor

#123036
Need change

Copy link
Copy Markdown
Member

@picnixz are you waiting on anything for this? You haven't triggered a request for a re-review.

picnixz commented Sep 17, 2024

Copy link
Copy Markdown
Member Author

Oh I forgot about it. This one is a low-priority task (which is why I didn't re-request a review) and we were waiting for more experts feedback (such as yours I think?) so we can address this issue when people have the time!

(I'll be barely present for the rest of the week)

hugovk commented Oct 15, 2024

Copy link
Copy Markdown
Member

Where are we up to here?

Our friends at Fedora, who do a huge amount of valuable early testing and fixing of Python packages, are asking about pending deprecations for 3.14:

https://discuss.python.org/t/if-you-plan-to-remove-deprecated-apis-from-python-3-14-please-do-it-now/67955

picnixz commented Oct 15, 2024

Copy link
Copy Markdown
Member Author

I always forget about this PR :D We actually waited for an expert on pkgutil to confirm that the removal is ok. Apart from that, I don't think I wanted to do more. I'll ask a round of re-review.

picnixz requested review from hugovk, sobolevn and warsaw October 15, 2024 13:12

Copy link
Copy Markdown
Member

We actually waited for an expert on pkgutil to confirm that the removal is ok

There is no pkgutil expert, hence the deprecation (that and it not plugging into importlib cleanly). 😉

hugovk commented Nov 1, 2024

Copy link
Copy Markdown
Member

Let's merge!

hugovk merged commit 464a7a9 into python:main Nov 1, 2024
picnixz deleted the remove-deprecated-pkgutil branch November 1, 2024 16:39
picnixz added a commit to picnixz/cpython that referenced this pull request Dec 8, 2024
…til`` (python#119656) Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com> Co-authored-by: Brett Cannon <brett@python.org>
ebonnal pushed a commit to ebonnal/cpython that referenced this pull request Jan 12, 2025
…til`` (python#119656) Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com> Co-authored-by: Brett Cannon <brett@python.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

Footer

© 2026 GitHub, Inc.