← 返回首页
gh-117657: Fix missing atomic in dict_resize by DinoV · Pull Request #119312 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

gh-117657: Fix missing atomic in dict_resize#119312

Merged
DinoV merged 1 commit into
python:mainfrom
DinoV:nogil_dict_resize
May 22, 2024
Merged

gh-117657: Fix missing atomic in dict_resize#119312
DinoV merged 1 commit into
python:mainfrom
DinoV:nogil_dict_resize

Conversation

DinoV commented May 21, 2024 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

Use atomic to assign to PyDictValues->valid like we do elsewhere

DinoV requested review from markshannon and methane as code owners May 21, 2024 14:44
DinoV requested review from colesbury and removed request for markshannon and methane May 21, 2024 14:44
bedevere-app Bot mentioned this pull request May 21, 2024
Closed
colesbury approved these changes May 21, 2024
View reviewed changes

colesbury left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

We should backport this to 3.13

DinoV added the needs backport to 3.13 bugs and security fixes label May 22, 2024

DinoV commented May 22, 2024

Copy link
Copy Markdown
Contributor Author

We should backport this to 3.13

Backport to 3.13: #119416

DinoV merged commit 2b3fb76 into python:main May 22, 2024

miss-islington-app Bot commented May 22, 2024

Copy link
Copy Markdown

Thanks @DinoV for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 22, 2024
pythongh-117657: Fix missing atomic in dict_resize (pythonGH-119312) …
95b016a
Fix missing atomic in dict_resize (cherry picked from commit 2b3fb76) Co-authored-by: Dino Viehland <dinoviehland@meta.com>

bedevere-app Bot commented May 22, 2024

Copy link
Copy Markdown

GH-119417 is a backport of this pull request to the 3.13 branch.

bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label May 22, 2024
DinoV added a commit that referenced this pull request May 22, 2024
[3.13] gh-117657: Fix missing atomic in dict_resize (GH-119312) (#119417 …
cd35e9d
) gh-117657: Fix missing atomic in dict_resize (GH-119312) Fix missing atomic in dict_resize (cherry picked from commit 2b3fb76) Co-authored-by: Dino Viehland <dinoviehland@meta.com>
JelleZijlstra mentioned this pull request May 28, 2024
Closed
DinoV deleted the nogil_dict_resize branch May 31, 2024 18:21
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
pythongh-117657: Fix missing atomic in dict_resize (python#119312) …
6c5ee0d
Fix missing atomic in dict_resize
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

colesbury colesbury approved these changes

Assignees

No one assigned

Labels

skip news topic-free-threading

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Footer

© 2026 GitHub, Inc.