← 返回首页
gh-118692: Avoid creating unnecessary StopIteration instances for monitoring by iritkatriel · Pull Request #119216 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

gh-118692: Avoid creating unnecessary StopIteration instances for monitoring#119216

Merged
iritkatriel merged 5 commits into
python:mainfrom
iritkatriel:monitoring_stopIteration
May 21, 2024
Merged

gh-118692: Avoid creating unnecessary StopIteration instances for monitoring#119216
iritkatriel merged 5 commits into
python:mainfrom
iritkatriel:monitoring_stopIteration

Conversation

iritkatriel commented May 20, 2024 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

iritkatriel requested a review from scoder May 20, 2024 14:55
bedevere-app Bot mentioned this pull request May 20, 2024
Closed
iritkatriel removed the request for review from gvanrossum May 20, 2024 14:55
markshannon requested changes May 20, 2024
View reviewed changes

markshannon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

Possible NULL dereference needs fixing. Looks good, otherwise.

Comment thread Python/instrumentation.c Show resolved Hide resolved

bedevere-app Bot commented May 20, 2024

Copy link
Copy Markdown

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

iritkatriel commented May 21, 2024

Copy link
Copy Markdown
Member Author

I have made the requested changes; please review again.

bedevere-app Bot commented May 21, 2024

Copy link
Copy Markdown

Thanks for making the requested changes!

@markshannon: please review the changes made to this pull request.

bedevere-app Bot requested a review from markshannon May 21, 2024 17:51
iritkatriel enabled auto-merge (squash) May 21, 2024 20:02
iritkatriel merged commit 6e9863d into python:main May 21, 2024

scoder commented May 24, 2024

Copy link
Copy Markdown
Contributor

This needs backporting to 3.13.

scoder added the needs backport to 3.13 bugs and security fixes label May 24, 2024

miss-islington-app Bot commented May 24, 2024

Copy link
Copy Markdown

Thanks @iritkatriel for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 24, 2024
pythongh-118692: Avoid creating unnecessary StopIteration instances f… …
06943e2
…or monitoring (pythonGH-119216) (cherry picked from commit 6e9863d) Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>

bedevere-app Bot commented May 24, 2024

Copy link
Copy Markdown

GH-119497 is a backport of this pull request to the 3.13 branch.

bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label May 24, 2024
scoder added the 3.13 bugs and security fixes label May 24, 2024
iritkatriel added a commit that referenced this pull request May 24, 2024
[3.13] gh-118692: Avoid creating unnecessary StopIteration instances … …
c864efb
…for monitoring (GH-119216) (#119497) * gh-118692: Avoid creating unnecessary StopIteration instances for monitoring (GH-119216) (cherry picked from commit 6e9863d) --------- Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
JelleZijlstra mentioned this pull request May 28, 2024
Closed
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
pythongh-118692: Avoid creating unnecessary StopIteration instances f… …
4eb906e
…or monitoring (python#119216)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

markshannon markshannon approved these changes
scoder Awaiting requested review from scoder

Assignees

No one assigned

Labels

3.13 bugs and security fixes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Avoid creating a StopIteration instance for monitoring

3 participants

Footer

© 2026 GitHub, Inc.