← 返回首页
gh-118846: Fix PGO tests in free-threaded build by colesbury · Pull Request #118862 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

gh-118846: Fix PGO tests in free-threaded build#118862

Merged
colesbury merged 1 commit into
python:mainfrom
colesbury:gh-118846-pgo-tests
May 9, 2024
Merged

gh-118846: Fix PGO tests in free-threaded build#118862
colesbury merged 1 commit into
python:mainfrom
colesbury:gh-118846-pgo-tests

Conversation

colesbury commented May 9, 2024 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

Avoid immortalizing objects in tests that verify garbage collection of classes or modules.

This fixes test_ordered_dict and test_struct.

pythongh-118846: Fix PGO tests in free-threaded build …
f203ebf
Avoid immortalizing objects in some tests that test behavior of collecting classes or modules. This fixes test_ordered_dict and test_struct.
colesbury added tests Tests in the Lib/test dir skip news topic-free-threading needs backport to 3.13 bugs and security fixes labels May 9, 2024
colesbury requested a review from DinoV May 9, 2024 18:28
bedevere-app Bot mentioned this pull request May 9, 2024
Closed

colesbury commented May 9, 2024

Copy link
Copy Markdown
Contributor Author

cc @hroncok - I'll look at the other tests next, but this should be enough to fix the PGO build.

hroncok commented May 9, 2024

Copy link
Copy Markdown
Contributor

but this should be enough to fix the PGO build.

Indeed it is. Thanks.

colesbury mentioned this pull request May 9, 2024
Merged
DinoV approved these changes May 9, 2024
View reviewed changes

DinoV left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

LGTM!

colesbury merged commit 1b1db2f into python:main May 9, 2024

miss-islington-app Bot commented May 9, 2024

Copy link
Copy Markdown

Thanks @colesbury for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

colesbury deleted the gh-118846-pgo-tests branch May 9, 2024 20:06
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 9, 2024
pythongh-118846: Fix PGO tests in free-threaded build (pythonGH-118862) …
89b8e85
Avoid immortalizing objects in tests that verify garbage collection of classes or modules. This fixes test_ordered_dict and test_struct. (cherry picked from commit 1b1db2f) Co-authored-by: Sam Gross <colesbury@gmail.com>

bedevere-app Bot commented May 9, 2024

Copy link
Copy Markdown

GH-118867 is a backport of this pull request to the 3.13 branch.

bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label May 9, 2024
colesbury added a commit that referenced this pull request May 9, 2024
[3.13] gh-118846: Fix PGO tests in free-threaded build (GH-118862) (#… …
d4c6948
…118867) Avoid immortalizing objects in tests that verify garbage collection of classes or modules. This fixes test_ordered_dict and test_struct. (cherry picked from commit 1b1db2f) Co-authored-by: Sam Gross <colesbury@gmail.com>
SonicField pushed a commit to SonicField/cpython that referenced this pull request May 10, 2024
pythongh-118846: Fix PGO tests in free-threaded build (python#118862) …
888d3d7
Avoid immortalizing objects in tests that verify garbage collection of classes or modules. This fixes test_ordered_dict and test_struct.
JelleZijlstra mentioned this pull request May 28, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

DinoV DinoV approved these changes
+1 more reviewer
hroncok hroncok approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir topic-free-threading

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Footer

© 2026 GitHub, Inc.