← 返回首页
gh-116984: Make mimalloc header includes relative to the current file by colesbury · Pull Request #118808 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

gh-116984: Make mimalloc header includes relative to the current file#118808

Merged
colesbury merged 1 commit into
python:mainfrom
colesbury:gh-116984-mimalloc-include-path
May 9, 2024
Merged

gh-116984: Make mimalloc header includes relative to the current file#118808
colesbury merged 1 commit into
python:mainfrom
colesbury:gh-116984-mimalloc-include-path

Conversation

colesbury commented May 8, 2024 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

Some embedders and extensions include parts of the internal API. The pycore_mimalloc.h file is transitively include by a number of other internal headers. This avoids include errors for code that was already including those headers.

pythongh-116984: Make mimalloc header includes relative to the curren… …
74ebbee
…t file Some embedders and extensions include parts of the internal API. The pycore_mimalloc.h file is transitively include by a number of other internal headers. This avoids include errors for code that was already including those headers.
colesbury requested a review from DinoV May 8, 2024 23:28
bedevere-app Bot mentioned this pull request May 8, 2024
Closed
colesbury marked this pull request as ready for review May 8, 2024 23:35
colesbury added needs backport to 3.13 bugs and security fixes and removed awaiting core review labels May 8, 2024

colesbury commented May 9, 2024

Copy link
Copy Markdown
Contributor Author

cc @oraluben and @albanD

DinoV approved these changes May 9, 2024
View reviewed changes

DinoV left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

LGTM!

colesbury merged commit 71cc065 into python:main May 9, 2024
colesbury deleted the gh-116984-mimalloc-include-path branch May 9, 2024 20:03

miss-islington-app Bot commented May 9, 2024

Copy link
Copy Markdown

Thanks @colesbury for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 9, 2024
pythongh-116984: Make mimalloc header includes relative to the curren… …
41973dc
…t file (pythonGH-118808) Some embedders and extensions include parts of the internal API. The pycore_mimalloc.h file is transitively include by a number of other internal headers. This avoids include errors for code that was already including those headers. (cherry picked from commit 71cc065) Co-authored-by: Sam Gross <colesbury@gmail.com>

bedevere-app Bot commented May 9, 2024

Copy link
Copy Markdown

GH-118866 is a backport of this pull request to the 3.13 branch.

bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label May 9, 2024
colesbury mentioned this pull request May 9, 2024
Open
colesbury added a commit that referenced this pull request May 9, 2024
[3.13] gh-116984: Make mimalloc header includes relative to the curre… …
0a23970
…nt file (GH-118808) (#118866) Some embedders and extensions include parts of the internal API. The pycore_mimalloc.h file is transitively include by a number of other internal headers. This avoids include errors for code that was already including those headers. (cherry picked from commit 71cc065) Co-authored-by: Sam Gross <colesbury@gmail.com>
SonicField pushed a commit to SonicField/cpython that referenced this pull request May 10, 2024
pythongh-116984: Make mimalloc header includes relative to the curren… …
e0bb384
…t file (python#118808) Some embedders and extensions include parts of the internal API. The pycore_mimalloc.h file is transitively include by a number of other internal headers. This avoids include errors for code that was already including those headers.
JelleZijlstra mentioned this pull request May 28, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

DinoV DinoV approved these changes

Assignees

No one assigned

Labels

topic-C-API

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Footer

© 2026 GitHub, Inc.