← 返回首页
gh-74929: locals() documentation update for PEP 667 by ncoghlan · Pull Request #118265 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

gh-74929: locals() documentation update for PEP 667#118265

Merged
ncoghlan merged 3 commits into
python:mainfrom
ncoghlan:pep-667-locals-docs
May 6, 2024
Merged

gh-74929: locals() documentation update for PEP 667#118265
ncoghlan merged 3 commits into
python:mainfrom
ncoghlan:pep-667-locals-docs

Conversation

ncoghlan commented Apr 25, 2024 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

Proposed documentation wording taken from the
withdrawn PEP 558 (which had switched to the
Python level semantics proposed in PEP 667 prior
to its withdrawal).

📚 Documentation preview 📚: https://cpython-previews--118265.org.readthedocs.build/

locals() docs update for PEP 667 …
c843d7b
Proposed documentation wording taken from the withdrawn PEP 558 (which had switched to the Python level semantics proposed in PEP 667 prior to its withdrawal).
ncoghlan added docs Documentation in the Doc dir DO-NOT-MERGE labels Apr 25, 2024

ncoghlan commented Apr 25, 2024

Copy link
Copy Markdown
Contributor Author

DO-NOT-MERGE label added, as this should only be merged after the PEP 667 implementation in #115153 has been completed and merged.

ncoghlan commented Apr 26, 2024
View reviewed changes
Comment thread Doc/library/functions.rst Show resolved Hide resolved
ncoghlan changed the title locals() documentation update for PEP 667 gh-74929: locals() documentation update for PEP 667 Apr 26, 2024
bedevere-app Bot mentioned this pull request Apr 26, 2024
Closed

nineteendo commented Apr 26, 2024

Copy link
Copy Markdown
Contributor

Wouldn't it better to convert the pull request back to a draft? GitHub automatically prevents you from merging those.

ncoghlan self-assigned this Apr 28, 2024
ncoghlan marked this pull request as draft April 28, 2024 10:04

ncoghlan commented Apr 28, 2024

Copy link
Copy Markdown
Contributor Author

Wouldn't it better to convert the pull request back to a draft? GitHub automatically prevents you from merging those.

Good point, done (enough years of experience where draft PRs weren't available that I still forget to use them when appropriate)

ncoghlan commented Apr 28, 2024
View reviewed changes
Comment thread Doc/library/functions.rst
implicitly refreshed by other operations, such as calling ``locals()``
again. Obtaining the legacy CPython behaviour now requires explicit
calls to update the initially returned dictionary with the results
of subsequent calls to ``locals()``.

ncoghlan Apr 28, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

I plan to eventually replace the latter two sentences here with something like "For details, refer to the 'Python 3.13 porting guide'" (with a link to the relevant part of the 3.13 What's New document). That will be in a later PR that adds an initial version of the What's New update for PEP 667, though.

ncoghlan marked this pull request as ready for review May 6, 2024 10:04
ncoghlan merged commit 757fd3e into python:main May 6, 2024
ncoghlan mentioned this pull request May 6, 2024
Closed
SonicField pushed a commit to SonicField/cpython that referenced this pull request May 8, 2024
pythongh-74929: locals() documentation update for PEP 667 (python#118265 …
7ccecd1
) Documentation wording taken from the withdrawn PEP 558 (which had switched to the Python level semantics proposed in PEP 667 prior to its withdrawal).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

ncoghlan

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Footer

© 2026 GitHub, Inc.