← 返回首页
gh-76785: Fix Windows Refleak in test_interpreters by ericsnowcurrently · Pull Request #117913 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

gh-76785: Fix Windows Refleak in test_interpreters#117913

Merged
ericsnowcurrently merged 2 commits into
python:mainfrom
ericsnowcurrently:fix-windows-refleak
Apr 16, 2024
Merged

gh-76785: Fix Windows Refleak in test_interpreters#117913
ericsnowcurrently merged 2 commits into
python:mainfrom
ericsnowcurrently:fix-windows-refleak

Conversation

ericsnowcurrently commented Apr 16, 2024 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

gh-117662 introduced some refleaks, or, rather, exposed some existing refleaks. The leaks are coming when test.support.os_helper is imported in a "legacy" interpreter. I've updated test.test_interpreters.utils to avoid importing os_helper, which fixes the leaks. I'll address the root cause separately.

bedevere-app Bot mentioned this pull request Apr 16, 2024
Closed

ericsnowcurrently commented Apr 16, 2024

Copy link
Copy Markdown
Member Author

!buildbot AMD64 Windows11 Refleaks

bedevere-bot commented Apr 16, 2024

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @ericsnowcurrently for commit c0e665b 🤖

The command will test the builders whose names match following regular expression: AMD64 Windows11 Refleaks

The builders matched are:

  • AMD64 Windows11 Refleaks PR

ericsnowcurrently merged commit 3831144 into python:main Apr 16, 2024
ericsnowcurrently deleted the fix-windows-refleak branch April 16, 2024 02:16

encukou commented Apr 16, 2024

Copy link
Copy Markdown
Member

Thank you!

ericsnowcurrently mentioned this pull request Apr 16, 2024
Open
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
pythongh-76785: Fix Windows Refleak in test_interpreters (pythongh-11… …
8135251
…7913) pythongh-117662 introduced some refleaks, or, rather, exposed some existing refleaks. The leaks are coming when test.support.os_helper is imported in a "legacy" interpreter. I've updated test.test_interpreters.utils to avoid importing os_helper, which fixes the leaks. I'll address the root cause separately.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Footer

© 2026 GitHub, Inc.