← 返回首页
gh-113308: Restore `uuid._load_system_functions` for 3.13 by gpshead · Pull Request #117832 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
Resetting focus

gh-113308: Restore uuid._load_system_functions for 3.13#117832

Closed
gpshead wants to merge 2 commits into
python:mainfrom
gpshead:restore-uuid_load_system_functions
Closed

gh-113308: Restore uuid._load_system_functions for 3.13#117832
gpshead wants to merge 2 commits into
python:mainfrom
gpshead:restore-uuid_load_system_functions

Conversation

gpshead commented Apr 13, 2024
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

The do nothing private uuid._load_system_functions() function has been restored to appease a PyPI library that calls it to unblock 3.13 testing by others. It now triggers a :exc:DeprecationWarning instead.

This should deal with users blocked by the library on PyPI using the no-op from testing on 3.13:
spulec/freezegun#534 (comment)

The do nothing private ``uuid._load_system_functions()`` function has been restored to appease a PyPI library that calls it to unblock 3.13 testing by others. It now triggers a :exc:`DeprecationWarning` instead.

gpshead commented Apr 13, 2024

Copy link
Copy Markdown
Member Author

The PR that removed it was #115934.

gpshead requested a review from encukou April 13, 2024 01:41

aeros commented Apr 13, 2024

Copy link
Copy Markdown
Contributor

I did a search across all repositories using _load_system_functions() and it seems like it is wise to keep it around for some time. https://github.com/search?q=%22_load_system_functions%28%29%22&type=code&p=2

hugovk commented Apr 13, 2024

Copy link
Copy Markdown
Member

Those search results look like they're in forks of CPython or the freezegun library, so it doesn't look like it's actually used much (see also my search in gh-113308).

I'm absolutely fine with merging this, but am I right that it's not needed if freezegun makes a new release?

If so, may I suggest waiting until a bit closer to the next 3.13 release (beta 1, 2024-05-07), to give them a chance to make a release?

gpshead commented Apr 13, 2024

Copy link
Copy Markdown
Member Author

am I right that it's not needed if freezegun makes a new release?

Quite possibly. I'm just doing it to be conservative so that even if that doesn't happen we'll unblock things from our end on this issue.

Copy link
Copy Markdown

FYI @hugovk @gpshead : freezegun just had a release where the call to uuid._load_system_functions() is gated, so this seems indeed no longer necessary

gpshead commented Apr 24, 2024

Copy link
Copy Markdown
Member Author

sweet, thanks!

gpshead closed this Apr 24, 2024
gpshead deleted the restore-uuid_load_system_functions branch April 24, 2024 03:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting core review docs Documentation in the Doc dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Footer

© 2026 GitHub, Inc.