gh-76785: Minor Improvements to "interpreters" Module#116328

ericsnowcurrently

This includes adding pickle support to various classes, and small changes in the low-level _xxinterpqueues module that improve maintainability.

Issue: [subinterpreters] PEP 554 implementation: add interpreters module #76785

terryjreedy

New warnings when compile on Windows. I suspect from this PR since compiled yesterday.

f:\dev\3x\Modules\_xxinterpqueuesmodule.c(753,25): warning C4477: 'fprintf' : f ormat string '%ld' requires an argument of type 'long', but variadic argument 1 has type 'int64_t' [f:\dev\3x\PCbuild\pythoncore.vcxproj] f:\dev\3x\Modules\_xxinterpqueuesmodule.c(761,25): warning C4477: 'fprintf' : f ormat string '%ld' requires an argument of type 'long', but variadic argument 1 has type 'int64_t' [f:\dev\3x\PCbuild\pythoncore.vcxproj] f:\dev\3x\Modules\_xxinterpqueuesmodule.c(761,25): warning C4477: 'fprintf' : f ormat string '%ld' requires an argument of type 'long', but variadic argument 2 has type 'Py_ssize_t' [f:\dev\3x\PCbuild\pythoncore.vcxproj]

ericsnowcurrently

I'll take a look.

ericsnowcurrently added 10 commits March 4, 2024 14:22

Make Interpreter instances pickleable.

efd5f33

Make interpreters.Queue instances pickleable.

acd472a

Make interpreters.*Channel instances pickleable.

98a03d2

Raise QueueNotFoundError from _interpqueues.release().

46c6fb5

Combine the two QueueEmpty (and QueueFull) exception types.

7df489d

Fix docstrings in the low-level module.

dddd40b

get_default_fmt -> get_queue_defaults

512bed1

Drop the default arg from _interpqueues.get().

55e0e92

Add low-level tests.

b15e706

_PyCrossInterpreterData_UnregisterClass -> clear_xid_class

38fe300

ericsnowcurrently added the skip news label Mar 4, 2024

bedevere-app Bot added the awaiting core review label Mar 4, 2024

bedevere-app Bot mentioned this pull request Mar 4, 2024

[subinterpreters] PEP 554 implementation: add interpreters module #76785

Closed

ericsnowcurrently mentioned this pull request Mar 4, 2024

_xxinterpqueues.get return strange value, when the queue is empty #116239

Closed

ericsnowcurrently added 2 commits March 4, 2024 15:37

Destroy any remaining queues.

9496113

Do not crash for an unbalanced queue release.

5645bcf

ericsnowcurrently mentioned this pull request Mar 4, 2024

New warning: ‘fmt’ may be used uninitialized in this function [-Wmaybe-uninitialized] #116102

Closed

ericsnowcurrently added 3 commits March 4, 2024 17:15

Fix a compiler warning.

c43da0c

Fix TestBase.tearDown().

50a84f4

Fix a compiler warning.

3bd92b7

ericsnowcurrently merged commit 4402b3c into python:main Mar 5, 2024

ericsnowcurrently deleted the interpreters-module-improvements branch March 5, 2024 15:54

bedevere-app Bot removed the awaiting core review label Mar 5, 2024

ericsnowcurrently mentioned this pull request Mar 5, 2024

gh-76785: Use PRId64 to Fix a Compiler Warning on Windows #116369

Merged

ericsnowcurrently added a commit that referenced this pull request Mar 5, 2024

gh-76785 : Use PRId64 to Fix a Compiler Warning on Windows (gh-116369 ) …

dab85e0

I accidentally introduced the warning in gh-116328.

adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 25, 2024

pythongh-76785 : Use PRId64 to Fix a Compiler Warning on Windows (pyth… …

2e66c30

…ongh-116369) I accidentally introduced the warning in pythongh-116328.

diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024

pythongh-76785 : Use PRId64 to Fix a Compiler Warning on Windows (pyth… …

b50e523

…ongh-116369) I accidentally introduced the warning in pythongh-116328.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

gh-76785: Minor Improvements to "interpreters" Module#116328