← 返回首页
gh-113308: Remove some internal parts of `uuid` module by sobolevn · Pull Request #115934 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

gh-113308: Remove some internal parts of uuid module#115934

Merged
sobolevn merged 9 commits into
python:mainfrom
sobolevn:issue-113308
Mar 14, 2024
Merged

gh-113308: Remove some internal parts of uuid module#115934
sobolevn merged 9 commits into
python:mainfrom
sobolevn:issue-113308

Conversation

sobolevn commented Feb 26, 2024 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

Tests do not produce any warnings:

» ./python.exe -m test test_uuid Using random seed: 3734037146 0:00:00 load avg: 1.55 Run 1 test sequentially 0:00:00 load avg: 1.55 [1/1] test_uuid == Tests result: SUCCESS == 1 test OK. Total duration: 401 ms Total tests: run=72 skipped=13 Total test files: run=1/1 Result: SUCCESS

I didn't add any explicit tests for unused deprecated functions. I can, if needed.

📚 Documentation preview 📚: https://cpython-previews--115934.org.readthedocs.build/

sobolevn requested review from gpshead and hugovk February 26, 2024 07:16
bedevere-app Bot mentioned this pull request Feb 26, 2024
Closed
hugovk reviewed Feb 26, 2024
View reviewed changes
Comment thread Doc/whatsnew/3.13.rst Outdated Show resolved Hide resolved
sobolevn requested a review from hugovk February 26, 2024 09:11
sobolevn changed the title gh-113308: Deprecate some internal parts of uuid module gh-113308: Remove some internal parts of uuid module Mar 3, 2024
hugovk reviewed Mar 3, 2024
View reviewed changes
Comment thread Lib/test/test_uuid.py Outdated Show resolved Hide resolved
Update Lib/test/test_uuid.py …
0eec764
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
sobolevn requested review from gpshead and hugovk March 13, 2024 06:40
vstinner approved these changes Mar 14, 2024
View reviewed changes

vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

LGTM

sobolevn merged commit 61f576a into python:main Mar 14, 2024
vstinner pushed a commit to vstinner/cpython that referenced this pull request Mar 20, 2024
pythongh-113308: Remove some internal parts of uuid module (python#… …
c742f43
…115934) Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 25, 2024
pythongh-113308: Remove some internal parts of uuid module (python#… …
705e327
…115934) Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
gpshead mentioned this pull request Apr 13, 2024
Closed
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
pythongh-113308: Remove some internal parts of uuid module (python#… …
e5561b3
…115934) Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
ericfrederich mentioned this pull request Oct 16, 2024
Closed
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

vstinner vstinner approved these changes
hugovk hugovk approved these changes
gpshead Awaiting requested review from gpshead

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Footer

© 2026 GitHub, Inc.