← 返回首页
gh-67693: Fix urlunparse() and urlunsplit() for URIs with path starting with multiple slashes and no authority by serhiy-storchaka · Pull Request #113563 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

gh-67693: Fix urlunparse() and urlunsplit() for URIs with path starting with multiple slashes and no authority#113563

Merged
serhiy-storchaka merged 10 commits into
python:mainfrom
serhiy-storchaka:urls2
May 14, 2024
Merged

gh-67693: Fix urlunparse() and urlunsplit() for URIs with path starting with multiple slashes and no authority#113563
serhiy-storchaka merged 10 commits into
python:mainfrom
serhiy-storchaka:urls2

Conversation

serhiy-storchaka commented Dec 29, 2023 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

serhiy-storchaka added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Dec 29, 2023
bedevere-app Bot mentioned this pull request Dec 29, 2023
Closed
serhiy-storchaka mentioned this pull request Dec 29, 2023
Closed
serhiy-storchaka changed the title gh-78457: Fix urlunparse() and urlunsplit() for URIs with path starting with multiple slashes and no authority gh-67693: Fix urlunparse() and urlunsplit() for URIs with path starting with multiple slashes and no authority Dec 29, 2023

serhiy-storchaka commented Dec 29, 2023

Copy link
Copy Markdown
Member Author

It fixes also more serious security issue #67693.

serhiy-storchaka added the type-security A security issue label Dec 29, 2023
vadmium mentioned this pull request Apr 28, 2024
Open
serhiy-storchaka added the needs backport to 3.13 bugs and security fixes label May 9, 2024
vadmium reviewed May 12, 2024
View reviewed changes

vadmium left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

The code changes and tests look good to me.

Comment thread Misc/NEWS.d/next/Library/2019-08-27-01-16-50.gh-issue-67693.4NIAiy.rst Show resolved Hide resolved
serhiy-storchaka commented May 13, 2024
View reviewed changes
Comment thread Lib/test/test_urlparse.py
('//path/to/file',
('', 'path', '/to/file', '', '', ''),
('', 'path', '/to/file', '', '')),
('////path/to/file',

serhiy-storchaka May 13, 2024

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

This case was broken.

Comment thread Lib/test/test_urlparse.py
('scheme://path/to/file',
('scheme', 'path', '/to/file', '', '', ''),
('scheme', 'path', '/to/file', '', '')),
('scheme:////path/to/file',

serhiy-storchaka May 13, 2024

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

This case was broken.

Comment thread Lib/test/test_urlparse.py
('file:///tmp/junk.txt',
('file', '', '/tmp/junk.txt', '', '', ''),
('file', '', '/tmp/junk.txt', '', '')),
('file:////tmp/junk.txt',

serhiy-storchaka May 13, 2024

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

This case was broken.

Comment thread Lib/test/test_urlparse.py
('file:////tmp/junk.txt',
('file', '', '//tmp/junk.txt', '', '', ''),
('file', '', '//tmp/junk.txt', '', '')),
('file://///tmp/junk.txt',

serhiy-storchaka May 13, 2024

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

This case was broken.

sethmlarson approved these changes May 13, 2024
View reviewed changes

sethmlarson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

LGTM!

serhiy-storchaka merged commit e237b25 into python:main May 14, 2024

miss-islington-app Bot commented May 14, 2024

Copy link
Copy Markdown

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9, 3.10, 3.11, 3.12, 3.13.
🐍🍒⛏🤖

16 hidden items Load more…

bedevere-app Bot commented May 14, 2024

Copy link
Copy Markdown

GH-119025 is a backport of this pull request to the 3.11 branch.

bedevere-app Bot removed the needs backport to 3.11 only security fixes label May 14, 2024

bedevere-app Bot commented May 14, 2024

Copy link
Copy Markdown

GH-119026 is a backport of this pull request to the 3.10 branch.

bedevere-app Bot removed the needs backport to 3.10 only security fixes label May 14, 2024
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request May 14, 2024
[3.10] pythongh-67693: Fix urlunparse() and urlunsplit() for URIs wit… …
2b1df88
…h path starting with multiple slashes and no authority (pythonGH-113563) (cherry picked from commit e237b25) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>

bedevere-app Bot commented May 14, 2024

Copy link
Copy Markdown

GH-119027 is a backport of this pull request to the 3.9 branch.

serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request May 14, 2024
[3.9] pythongh-67693: Fix urlunparse() and urlunsplit() for URIs with… …
ba0a885
… path starting with multiple slashes and no authority (pythonGH-113563) (cherry picked from commit e237b25) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>

bedevere-app Bot commented May 14, 2024

Copy link
Copy Markdown

GH-119028 is a backport of this pull request to the 3.8 branch.

serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request May 14, 2024
[3.10] pythongh-67693: Fix urlunparse() and urlunsplit() for URIs wit… …
87d7223
…h path starting with multiple slashes and no authority (pythonGH-113563) (cherry picked from commit e237b25) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka added a commit that referenced this pull request May 14, 2024
[3.13] gh-67693: Fix urlunparse() and urlunsplit() for URIs with path… …
8720006
… starting with multiple slashes and no authority (GH-113563) (GH-119023) (cherry picked from commit e237b25) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka added a commit that referenced this pull request May 14, 2024
[3.12] gh-67693: Fix urlunparse() and urlunsplit() for URIs with path… …
387ff96
… starting with multiple slashes and no authority (GH-113563) (GH-119024) (cherry picked from commit e237b25) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka mentioned this pull request May 14, 2024
Closed
JelleZijlstra mentioned this pull request May 28, 2024
Closed
nineteendo mentioned this pull request Jun 12, 2024
Closed
matthewhughes934 mentioned this pull request Jun 23, 2024
Merged
matthewhughes934 pushed a commit to matthewhughes934/pip that referenced this pull request Jun 24, 2024
Split up Windows tests relying on urlunparse behaviour …
16f0617
There was a behavioural change to `urllib.parse.urlunparse`[1] that affects some of our tests on Windows. With the understanding that the new behaviour is indeed desired, split up some tests relying on this behaviour depending on the version of Python. The sample URL used to check this behaviour was taken from a test in the upstream change (with the new behaviour this URL will round-trip parsing) [1] python/cpython#113563
pradyunsg pushed a commit to pypa/pip that referenced this pull request Jun 25, 2024
Split up Windows tests relying on urlunparse behaviour (#12788) …
5c389ec
There was a behavioural change to `urllib.parse.urlunparse`[1] that affects some of our tests on Windows. With the understanding that the new behaviour is indeed desired, split up some tests relying on this behaviour depending on the version of Python. The sample URL used to check this behaviour was taken from a test in the upstream change (with the new behaviour this URL will round-trip parsing) [1] python/cpython#113563
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
pythongh-67693: Fix urlunparse() and urlunsplit() for URIs with path … …
73e7fcf
…starting with multiple slashes and no authority (pythonGH-113563)
This was referenced Jul 21, 2024
Closed
Merged
ambv pushed a commit that referenced this pull request Sep 4, 2024
[3.11] gh-67693: Fix urlunparse() and urlunsplit() for URIs with path… …
d0e8c10
… starting with multiple slashes and no authority (GH-113563) (#119025) (cherry picked from commit e237b25)
ambv pushed a commit that referenced this pull request Sep 4, 2024
[3.10] gh-67693: Fix urlunparse() and urlunsplit() for URIs with path… …
2fa5d70
… starting with multiple slashes and no authority (GH-113563) (#119026) (cherry picked from commit e237b25)
ambv added a commit that referenced this pull request Sep 4, 2024
[3.8] gh-67693: Fix urlunparse() and urlunsplit() for URIs with path … …
0a87812
…starting with multiple slashes and no authority (GH-113563) (#119028) (cherry picked from commit e237b25) Co-authored-by: Łukasz Langa <lukasz@langa.pl>
ambv added a commit that referenced this pull request Sep 5, 2024
[3.9] gh-67693: Fix urlunparse() and urlunsplit() for URIs with path … …
a5798d0
…starting with multiple slashes and no authority (GH-113563) (#119027) (cherry picked from commit e237b25) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com> Co-authored-by: Łukasz Langa <lukasz@langa.pl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

vadmium vadmium left review comments
sethmlarson sethmlarson approved these changes

Assignees

serhiy-storchaka

Labels

type-security A security issue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Footer

© 2026 GitHub, Inc.