← 返回首页
gh-113157 gh-89519: Fix method descriptors by rhettinger · Pull Request #113233 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

gh-113157 gh-89519: Fix method descriptors#113233

Merged
rhettinger merged 1 commit into
python:mainfrom
rhettinger:desc_chain_clean
Dec 21, 2023
Merged

gh-113157 gh-89519: Fix method descriptors#113233
rhettinger merged 1 commit into
python:mainfrom
rhettinger:desc_chain_clean

Conversation

rhettinger commented Dec 17, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Fix yet another problem created by classmethod descriptor chaining. This completes the work in gh-89519, fixes the bug reported in gh-113157, and get us back to the stable and correct semantics in Python 3.9.

There is still an open question about what if anything to do for Python 3.11 and Python 3.12. We can' t backport this without breaking something else.

bedevere-app Bot mentioned this pull request Dec 17, 2023
Open
rhettinger changed the title gh-113157 gh-89519: Restore behaviors before classmethod descriptor chaining was introduced gh-113157 gh-89519: Fix method descriptors Dec 17, 2023

mschmitzer commented Dec 18, 2023

Copy link
Copy Markdown

I think there's a typo in the commit message, you probably meant to reference gh-113157 ?

rhettinger merged commit d058eae into python:main Dec 21, 2023
facebook-github-bot pushed a commit to facebookincubator/cinder that referenced this pull request Dec 22, 2023
gh-89519 & gh-113157 (Remove classmethod descriptor chaining, depreca… …
f508768
…ted since 3.11) Summary: backport upstream PRs python/cpython#110163 and python/cpython#113233 upstream issues: python/cpython#89519 (Calling help executes classmethod property decorated methods) and python/cpython#113157 (Changed behavior of <instancemethod>.__get__ in Python 3.11) upstream commits: [`7f9a99e8549b792662f2cd28bf38a4d4625bd402`](python/cpython@7f9a99e) and [`d058eaeed44766a8291013b275ad22f153935d3b`](python/cpython@d058eae) Reviewed By: aleivag Differential Revision: D52014322 fbshipit-source-id: 87de6d9587bd9cc49f053ca340adfc469b041f91
ryan-duve pushed a commit to ryan-duve/cpython that referenced this pull request Dec 26, 2023
pythongh-113157 pythongh-89519: Fix method descriptors (pythongh-113233) …
278a514
Restore behaviors before classmethod descriptor chaining was introduced.
kulikjak pushed a commit to kulikjak/cpython that referenced this pull request Jan 22, 2024
pythongh-113157 pythongh-89519: Fix method descriptors (pythongh-113233) …
b9f2300
Restore behaviors before classmethod descriptor chaining was introduced.
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
pythongh-113157 pythongh-89519: Fix method descriptors (pythongh-113233) …
ead59a8
Restore behaviors before classmethod descriptor chaining was introduced.
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
pythongh-113157 pythongh-89519: Fix method descriptors (pythongh-113233) …
602f955
Restore behaviors before classmethod descriptor chaining was introduced.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Footer

© 2026 GitHub, Inc.