← 返回首页
gh-76785: Fix test_threading on Non-Subinterpreter Builds by ericsnowcurrently · Pull Request #113014 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

gh-76785: Fix test_threading on Non-Subinterpreter Builds#113014

Merged
ericsnowcurrently merged 1 commit into
python:mainfrom
ericsnowcurrently:fix-test-threading-s390
Dec 12, 2023
Merged

gh-76785: Fix test_threading on Non-Subinterpreter Builds#113014
ericsnowcurrently merged 1 commit into
python:mainfrom
ericsnowcurrently:fix-test-threading-s390

Conversation

ericsnowcurrently commented Dec 12, 2023 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

gh-112982 broke test_threading on one of the s390 buildbots (Fedora Clang Installed). Apparently ImportError is raised (rather than ModuleNotFoundError) for the name part of "from" imports. This fixes that by catching ImportError in test_threading.py.

bedevere-app Bot added tests Tests in the Lib/test dir awaiting core review labels Dec 12, 2023
bedevere-app Bot mentioned this pull request Dec 12, 2023
Closed
ericsnowcurrently mentioned this pull request Dec 12, 2023
Merged
ericsnowcurrently enabled auto-merge (squash) December 12, 2023 16:01
ericsnowcurrently merged commit cde1417 into python:main Dec 12, 2023
ericsnowcurrently deleted the fix-test-threading-s390 branch December 12, 2023 17:03
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
pythongh-76785: Fix test_threading on Non-Subinterpreter Builds (pyth… …
c2caa6f
…ongh-113014) pythongh-112982 broke test_threading on one of the s390 buildbots (Fedora Clang Installed). Apparently ImportError is raised (rather than ModuleNotFoundError) for the name part of "from" imports. This fixes that by catching ImportError in test_threading.py.
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
pythongh-76785: Fix test_threading on Non-Subinterpreter Builds (pyth… …
6e38b20
…ongh-113014) pythongh-112982 broke test_threading on one of the s390 buildbots (Fedora Clang Installed). Apparently ImportError is raised (rather than ModuleNotFoundError) for the name part of "from" imports. This fixes that by catching ImportError in test_threading.py.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

Footer

© 2026 GitHub, Inc.