← 返回首页
gh-94309: py312 "what's new": improve deprecation notice for typing.Hashable and typing.Sized by salty-horse · Pull Request #112196 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

gh-94309: py312 "what's new": improve deprecation notice for typing.Hashable and typing.Sized#112196

Merged
AlexWaygood merged 1 commit into
python:mainfrom
salty-horse:typing_deprecation_doc
Nov 17, 2023
Merged

gh-94309: py312 "what's new": improve deprecation notice for typing.Hashable and typing.Sized#112196
AlexWaygood merged 1 commit into
python:mainfrom
salty-horse:typing_deprecation_doc

Conversation

salty-horse commented Nov 17, 2023 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor

The documentation of the deprecation of typing aliases in 3.12 (#94309) was just the names of the aliases, without a description of what happens to them. This can cause confusion, even if it's in the "Deprecated" section of documentation, since all other items include this description.

This should be backported to 3.12.

📚 Documentation preview 📚: https://cpython-previews--112196.org.readthedocs.build/

bedevere-app Bot added awaiting review docs Documentation in the Doc dir skip news labels Nov 17, 2023
bedevere-app Bot mentioned this pull request Nov 17, 2023
Closed
AlexWaygood self-requested a review November 17, 2023 10:23
AlexWaygood changed the title gh-94309: Fix documentation for deprecated aliases gh-94309: py312 "what's new": improve deprecation notice for typing.Hashable and typing.Sized Nov 17, 2023
AlexWaygood reviewed Nov 17, 2023
View reviewed changes

AlexWaygood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

Thanks!

Comment thread Doc/whatsnew/3.12.rst Outdated Show resolved Hide resolved
salty-horse force-pushed the typing_deprecation_doc branch from 2f7fa98 to 5a776e7 Compare November 17, 2023 12:22
AlexWaygood approved these changes Nov 17, 2023
View reviewed changes

AlexWaygood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

Thank you!

AlexWaygood enabled auto-merge (squash) November 17, 2023 12:25
AlexWaygood self-assigned this Nov 17, 2023
AlexWaygood merged commit fb4cddb into python:main Nov 17, 2023

miss-islington-app Bot commented Nov 17, 2023

Copy link
Copy Markdown

Thanks @salty-horse for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 17, 2023
pythongh-94309: "What's new in Python 3.12": improve deprecation noti… …
4ebc12c
…ce for typing.Hashable and typing.Sized (pythonGH-112196) (cherry picked from commit fb4cddb) Co-authored-by: Ori Avtalion <ori@avtalion.name>

bedevere-app Bot commented Nov 17, 2023

Copy link
Copy Markdown

GH-112200 is a backport of this pull request to the 3.12 branch.

bedevere-app Bot removed the needs backport to 3.12 only security fixes label Nov 17, 2023
AlexWaygood pushed a commit that referenced this pull request Nov 17, 2023
[3.12] gh-94309: "What's new in Python 3.12": improve deprecation not… …
976488e
…ice for typing.Hashable and typing.Sized (GH-112196) (#112200) gh-94309: "What's new in Python 3.12": improve deprecation notice for typing.Hashable and typing.Sized (GH-112196) (cherry picked from commit fb4cddb) Co-authored-by: Ori Avtalion <ori@avtalion.name>
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
pythongh-94309: "What's new in Python 3.12": improve deprecation noti… …
74261c7
…ce for typing.Hashable and typing.Sized (python#112196)
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
pythongh-94309: "What's new in Python 3.12": improve deprecation noti… …
fc6b30a
…ce for typing.Hashable and typing.Sized (python#112196)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

AlexWaygood AlexWaygood approved these changes

Assignees

AlexWaygood

Labels

docs Documentation in the Doc dir skip news topic-typing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Footer

© 2026 GitHub, Inc.