← 返回首页
gh-76785: Add an Internal ExceptionSnapshot Type by ericsnowcurrently · Pull Request #111572 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

gh-76785: Add an Internal ExceptionSnapshot Type#111572

Closed
ericsnowcurrently wants to merge 7 commits into
python:mainfrom
ericsnowcurrently:crossinterp-utils-exc-snapshot
Closed

gh-76785: Add an Internal ExceptionSnapshot Type#111572
ericsnowcurrently wants to merge 7 commits into
python:mainfrom
ericsnowcurrently:crossinterp-utils-exc-snapshot

Conversation

ericsnowcurrently commented Oct 31, 2023 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

This will be used by _xxsubinterpretersmodule.c in a follow-up PR, though it should have utility on its own.

bedevere-app Bot mentioned this pull request Oct 31, 2023
Closed
ericsnowcurrently force-pushed the crossinterp-utils-exc-snapshot branch 2 times, most recently from 19bd5fc to b8ea359 Compare November 1, 2023 23:39
ericsnowcurrently marked this pull request as ready for review November 1, 2023 23:58
ericsnowcurrently removed the request for review from iritkatriel November 1, 2023 23:58
iritkatriel reviewed Nov 2, 2023
View reviewed changes
Comment thread Objects/exceptions.c
exctype = PyExc_RuntimeError;
}

_Py_excinfo_Apply(&self->info, exctype);

iritkatriel Nov 2, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

Where is this function defined?

ericsnowcurrently Nov 2, 2023

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

In Python/errors.c.

iritkatriel Nov 2, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

Ah I see, I needed to refresh my branch.

This looks like a DIY serialisation of exceptions. Does it work for all exception types? What if the args to the exception constructor are not just the msg string?

ericsnowcurrently mentioned this pull request Nov 3, 2023
Merged
ericsnowcurrently force-pushed the crossinterp-utils-exc-snapshot branch from b8ea359 to 29affcd Compare November 3, 2023 22:35
ericsnowcurrently added a commit that referenced this pull request Nov 6, 2023
gh-76785: Move _Py_excinfo Functions Out of the Internal C-API (gh-11… …
d4426e8
…1715) I added _Py_excinfo to the internal API (and added its functions in Python/errors.c) in gh-111530 (9322ce9). Since then I've had a nagging sense that I should have added the type and functions in its own PR. While I do plan on using _Py_excinfo outside crossinterp.c very soon (see gh-111572/gh-111573), I'd still feel more comfortable if the _Py_excinfo stuff went in as its own PR. Hence, here we are. (FWIW, I may combine that with gh-111572, which I may, in turn, combine with gh-111573. We'll see.)
ericsnowcurrently force-pushed the crossinterp-utils-exc-snapshot branch from 29affcd to b9f7974 Compare November 6, 2023 19:13
hugovk pushed a commit to hugovk/cpython that referenced this pull request Nov 8, 2023
pythongh-76785: Move _Py_excinfo Functions Out of the Internal C-API (p… …
8ac1b5b
…ythongh-111715) I added _Py_excinfo to the internal API (and added its functions in Python/errors.c) in pythongh-111530 (9322ce9). Since then I've had a nagging sense that I should have added the type and functions in its own PR. While I do plan on using _Py_excinfo outside crossinterp.c very soon (see pythongh-111572/pythongh-111573), I'd still feel more comfortable if the _Py_excinfo stuff went in as its own PR. Hence, here we are. (FWIW, I may combine that with pythongh-111572, which I may, in turn, combine with pythongh-111573. We'll see.)
ericsnowcurrently deleted the crossinterp-utils-exc-snapshot branch November 23, 2023 00:49
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
pythongh-76785: Move _Py_excinfo Functions Out of the Internal C-API (p… …
34fab73
…ythongh-111715) I added _Py_excinfo to the internal API (and added its functions in Python/errors.c) in pythongh-111530 (9322ce9). Since then I've had a nagging sense that I should have added the type and functions in its own PR. While I do plan on using _Py_excinfo outside crossinterp.c very soon (see pythongh-111572/pythongh-111573), I'd still feel more comfortable if the _Py_excinfo stuff went in as its own PR. Hence, here we are. (FWIW, I may combine that with pythongh-111572, which I may, in turn, combine with pythongh-111573. We'll see.)
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
pythongh-76785: Move _Py_excinfo Functions Out of the Internal C-API (p… …
049be32
…ythongh-111715) I added _Py_excinfo to the internal API (and added its functions in Python/errors.c) in pythongh-111530 (9322ce9). Since then I've had a nagging sense that I should have added the type and functions in its own PR. While I do plan on using _Py_excinfo outside crossinterp.c very soon (see pythongh-111572/pythongh-111573), I'd still feel more comfortable if the _Py_excinfo stuff went in as its own PR. Hence, here we are. (FWIW, I may combine that with pythongh-111572, which I may, in turn, combine with pythongh-111573. We'll see.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

iritkatriel iritkatriel left review comments

Assignees

No one assigned

Labels

awaiting core review skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Footer

© 2026 GitHub, Inc.