← 返回首页
gh-76785: Move the Cross-Interpreter Code to Its Own File by ericsnowcurrently · Pull Request #111502 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

gh-76785: Move the Cross-Interpreter Code to Its Own File#111502

Merged
ericsnowcurrently merged 8 commits into
python:mainfrom
ericsnowcurrently:crossinterp-utils-refactor
Oct 30, 2023
Merged

gh-76785: Move the Cross-Interpreter Code to Its Own File#111502
ericsnowcurrently merged 8 commits into
python:mainfrom
ericsnowcurrently:crossinterp-utils-refactor

Conversation

ericsnowcurrently commented Oct 30, 2023 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

This is partly to clear this stuff out of pystate.c, but also in preparation for moving some code out of _xxsubinterpretersmodule.c.

This change also moves this stuff to the internal API (new: Include/internal/pycore_crossinterp.h). @vstinner did this previously and I undid it. Now I'm re-doing it. :/

(This PR essentially only moves existing code between files.)

ericsnowcurrently requested a review from a team as a code owner October 30, 2023 16:00
bedevere-app Bot mentioned this pull request Oct 30, 2023
Closed
Eclips4 reviewed Oct 30, 2023
View reviewed changes
Comment thread Python/crossinterp.c Outdated Show resolved Hide resolved
ericsnowcurrently removed the request for review from a team October 30, 2023 18:17
vstinner approved these changes Oct 30, 2023
View reviewed changes

vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

LGTM.

Comment thread Include/internal/pycore_crossinterp.h
};

PyAPI_FUNC(_PyCrossInterpreterData *) _PyCrossInterpreterData_New(void);
PyAPI_FUNC(void) _PyCrossInterpreterData_Free(_PyCrossInterpreterData *data);

vstinner Oct 30, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

If you don't need one of these functions in shared libraries (stdlib extensions), you can replace PyAPI_FUNC() with extern.

ericsnowcurrently Oct 30, 2023

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

They're basically all used in _xxsubinterpretersmodule.c and _xxinterpchannelsmodule.c.

ericsnowcurrently merged commit c6fe086 into python:main Oct 30, 2023
ericsnowcurrently deleted the crossinterp-utils-refactor branch October 30, 2023 22:53
FullteaR pushed a commit to FullteaR/cpython that referenced this pull request Nov 3, 2023
pythongh-76785: Move the Cross-Interpreter Code to Its Own File (pyth… …
af89509
…ongh-111502) This is partly to clear this stuff out of pystate.c, but also in preparation for moving some code out of _xxsubinterpretersmodule.c. This change also moves this stuff to the internal API (new: Include/internal/pycore_crossinterp.h). @vstinner did this previously and I undid it. Now I'm re-doing it. :/
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
pythongh-76785: Move the Cross-Interpreter Code to Its Own File (pyth… …
3a4f933
…ongh-111502) This is partly to clear this stuff out of pystate.c, but also in preparation for moving some code out of _xxsubinterpretersmodule.c. This change also moves this stuff to the internal API (new: Include/internal/pycore_crossinterp.h). @vstinner did this previously and I undid it. Now I'm re-doing it. :/
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
pythongh-76785: Move the Cross-Interpreter Code to Its Own File (pyth… …
537057e
…ongh-111502) This is partly to clear this stuff out of pystate.c, but also in preparation for moving some code out of _xxsubinterpretersmodule.c. This change also moves this stuff to the internal API (new: Include/internal/pycore_crossinterp.h). @vstinner did this previously and I undid it. Now I'm re-doing it. :/
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Eclips4 Eclips4 left review comments
vstinner vstinner approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Footer

© 2026 GitHub, Inc.