← 返回首页
gh-80527: Change support.requires_legacy_unicode_capi() by vstinner · Pull Request #108438 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

gh-80527: Change support.requires_legacy_unicode_capi()#108438

Merged
vstinner merged 1 commit into
python:mainfrom
vstinner:unicode_legacy
Aug 24, 2023
Merged

gh-80527: Change support.requires_legacy_unicode_capi()#108438
vstinner merged 1 commit into
python:mainfrom
vstinner:unicode_legacy

Conversation

vstinner commented Aug 24, 2023 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

The decorator now requires to be called:

@support.requires_legacy_unicode_capi()

instead of:

@support.requires_legacy_unicode_capi

The implementation now only imports _testcapi when the decorator is called, so "import test.support" no longer imports the _testcapi extension.

pythongh-80527: Change support.requires_legacy_unicode_capi() …
dfc7f82
The decorator now requires to be called with parenthesis: @support.requires_legacy_unicode_capi() instead of: @support.requires_legacy_unicode_capi The implementation now only imports _testcapi when the decorator is called, so "import test.support" no longer imports the _testcapi extension.
vstinner requested a review from rhettinger as a code owner August 24, 2023 17:24
bedevere-bot mentioned this pull request Apr 10, 2022
Closed
vstinner merged commit 995f4c4 into python:main Aug 24, 2023
vstinner deleted the unicode_legacy branch August 24, 2023 18:09

miss-islington commented Aug 24, 2023

Copy link
Copy Markdown
Contributor

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

bedevere-bot commented Aug 24, 2023

Copy link
Copy Markdown

GH-108446 is a backport of this pull request to the 3.12 branch.

bedevere-bot removed the needs backport to 3.12 only security fixes label Aug 24, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 24, 2023
pythongh-80527: Change support.requires_legacy_unicode_capi() (python… …
628f162
…GH-108438) The decorator now requires to be called with parenthesis: @support.requires_legacy_unicode_capi() instead of: @support.requires_legacy_unicode_capi The implementation now only imports _testcapi when the decorator is called, so "import test.support" no longer imports the _testcapi extension. (cherry picked from commit 995f4c4) Co-authored-by: Victor Stinner <vstinner@python.org>
Yhg1s pushed a commit that referenced this pull request Aug 25, 2023
[3.12] gh-80527: Change support.requires_legacy_unicode_capi() (GH-10… …
0eb6d87
…8438) (#108446) gh-80527: Change support.requires_legacy_unicode_capi() (GH-108438) The decorator now requires to be called with parenthesis: @support.requires_legacy_unicode_capi() instead of: @support.requires_legacy_unicode_capi The implementation now only imports _testcapi when the decorator is called, so "import test.support" no longer imports the _testcapi extension. (cherry picked from commit 995f4c4) Co-authored-by: Victor Stinner <vstinner@python.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

rhettinger Awaiting requested review from rhettinger

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Footer

© 2026 GitHub, Inc.