← 返回首页
gh-91051: fix type watcher test to be robust to existing watcher by carljm · Pull Request #107989 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

gh-91051: fix type watcher test to be robust to existing watcher#107989

Merged
carljm merged 2 commits into
python:mainfrom
carljm:typewatchertest
Aug 16, 2023
Merged

gh-91051: fix type watcher test to be robust to existing watcher#107989
carljm merged 2 commits into
python:mainfrom
carljm:typewatchertest

Conversation

carljm commented Aug 16, 2023 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

One more case of a watcher test spuriously failing because a watcher is already installed. I think this should be the last one.

carljm requested a review from itamaro August 16, 2023 00:30
bedevere-bot mentioned this pull request Aug 16, 2023
Closed
bedevere-bot added awaiting core review tests Tests in the Lib/test dir labels Aug 16, 2023
itamaro approved these changes Aug 16, 2023
View reviewed changes
Comment thread Lib/test/test_capi/test_watchers.py Outdated Show resolved Hide resolved
carljm merged commit fce93c8 into python:main Aug 16, 2023

miss-islington commented Aug 16, 2023

Copy link
Copy Markdown
Contributor

Thanks @carljm for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

carljm deleted the typewatchertest branch August 16, 2023 19:13

bedevere-bot commented Aug 16, 2023

Copy link
Copy Markdown

GH-108053 is a backport of this pull request to the 3.12 branch.

bedevere-bot removed the needs backport to 3.12 only security fixes label Aug 16, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 16, 2023
pythongh-91051: fix type watcher test to be robust to existing watcher ( …
f785150
pythonGH-107989) (cherry picked from commit fce93c8) Co-authored-by: Carl Meyer <carl@oddbird.net>
Yhg1s pushed a commit that referenced this pull request Aug 16, 2023
[3.12] gh-91051: fix type watcher test to be robust to existing watch… …
84a4370
…er (GH-107989) (#108053) gh-91051: fix type watcher test to be robust to existing watcher (GH-107989) (cherry picked from commit fce93c8) Co-authored-by: Carl Meyer <carl@oddbird.net>
facebook-github-bot pushed a commit to facebookincubator/cinder that referenced this pull request Aug 17, 2023
use type watchers in JIT and shadowcode …
730e0e7
Summary: Use type watchers instead of direct calls for handling type modifications in JIT and shadowcode. Also backport python/cpython#107989 so the type watchers tests are resilient to there already being a type watcher installed. Reviewed By: alexmalyshev Differential Revision: D48340200 fbshipit-source-id: 25798b824bc231bd68f8ec7c4c81bb2fa84e3914
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

itamaro itamaro approved these changes

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Footer

© 2026 GitHub, Inc.