← 返回首页
gh-98931: Add custom error messages to invalid import/from with multiple targets by pablogsal · Pull Request #105985 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

gh-98931: Add custom error messages to invalid import/from with multiple targets#105985

Merged
pablogsal merged 2 commits into
python:mainfrom
pablogsal:gh-98931-2
Jun 22, 2023
Merged

gh-98931: Add custom error messages to invalid import/from with multiple targets#105985
pablogsal merged 2 commits into
python:mainfrom
pablogsal:gh-98931-2

Conversation

pablogsal commented Jun 22, 2023 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

pablogsal requested a review from lysnikolaou as a code owner June 22, 2023 13:20
bedevere-bot mentioned this pull request Mar 7, 2023
Closed

pablogsal commented Jun 22, 2023

Copy link
Copy Markdown
Member Author

@Yhg1s This is technically not a new error message but somehow an oversight (multiple targets were not supported). Are you ok adding this to 3.12?

Yhg1s commented Jun 22, 2023

Copy link
Copy Markdown
Member

Yeah, 👍 for getting this into 3.12b4.

pablogsal added the needs backport to 3.12 only security fixes label Jun 22, 2023
pythongh-98931: Add custom error messages to invalid import/from with… …
594e24f
… multiple targets Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
AlexWaygood reviewed Jun 22, 2023
View reviewed changes
Comment thread Misc/NEWS.d/next/Core and Builtins/2023-06-22-14-19-17.gh-issue-98931.PPgvSF.rst Outdated Show resolved Hide resolved
Update Misc/NEWS.d/next/Core and Builtins/2023-06-22-14-19-17.gh-issu… …
37d439e
…e-98931.PPgvSF.rst Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
pablogsal enabled auto-merge (squash) June 22, 2023 15:40
pablogsal merged commit 13237a2 into python:main Jun 22, 2023
pablogsal deleted the gh-98931-2 branch June 22, 2023 15:56

miss-islington commented Jun 22, 2023

Copy link
Copy Markdown
Contributor

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 22, 2023
pythongh-98931: Add custom error messages to invalid import/from with… …
0bb8b06
… multiple targets (pythonGH-105985) (cherry picked from commit 13237a2) Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com> Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>

bedevere-bot commented Jun 22, 2023

Copy link
Copy Markdown

GH-105991 is a backport of this pull request to the 3.12 branch.

bedevere-bot removed the needs backport to 3.12 only security fixes label Jun 22, 2023
pablogsal added a commit that referenced this pull request Jun 22, 2023
[3.12] gh-98931: Add custom error messages to invalid import/from wit… …
c407ef0
…h multiple targets (GH-105985) (#105991) Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com> Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
bentasker pushed a commit to bentasker/cpython that referenced this pull request Jun 23, 2023
pythongh-98931: Add custom error messages to invalid import/from with… …
44bea61
… multiple targets (python#105985) Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

AlexWaygood AlexWaygood left review comments
Yhg1s Yhg1s approved these changes
lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Footer

© 2026 GitHub, Inc.