← 返回首页
gh-89886: Use Autoconf quadrigraphs where appropriate by erlend-aasland · Pull Request #105226 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

gh-89886: Use Autoconf quadrigraphs where appropriate#105226

Merged
erlend-aasland merged 1 commit into
python:mainfrom
erlend-aasland:autoconf/quadrigraphs
Jun 7, 2023
Merged

gh-89886: Use Autoconf quadrigraphs where appropriate#105226
erlend-aasland merged 1 commit into
python:mainfrom
erlend-aasland:autoconf/quadrigraphs

Conversation

erlend-aasland commented Jun 2, 2023 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

erlend-aasland requested a review from corona10 as a code owner June 2, 2023 08:54
bedevere-bot mentioned this pull request Jun 2, 2023
Closed

erlend-aasland commented Jun 2, 2023

Copy link
Copy Markdown
Contributor Author

@corona10 are you ok with this? In my editor (Vim), this fix is very helpful, not specifically because of the highlighting, but also because it enables Vim to correctly recognise closing parentheses and brackets. This makes hacking Autoconf way easier, since I can quickly verify opening/closing brackets and parentheses using the % char.

corona10 commented Jun 2, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Yeah yeah, I understood what you intended. I have the same issue with my vim editor.
What do you think about writing documentation for configure.ac?
Now some semantics is not intuitive to the unfamiliar user. But if the documentation exists, it would be helpful to write new things or maintain the configure.ac

erlend-aasland commented Jun 2, 2023

Copy link
Copy Markdown
Contributor Author

What do you think about writing documentation for configure.ac?

I don't think we need to maintain our own Autoconf docs; the GNU Autoconf docs are well written and full of good examples.

corona10 reviewed Jun 2, 2023
View reviewed changes
Comment thread configure.ac Show resolved Hide resolved
corona10 requested a review from vstinner June 2, 2023 09:25
vstinner reviewed Jun 3, 2023
View reviewed changes

vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

The code correctly works as expected. %:@include is surprising and looks specific to autotools, whereas C uses #include. The benefit is to fix syntax highlight? I'm not convinced that it's worth it.

@corona10 are you ok with this? In my editor (Vim), this fix is very helpful, not specifically because of the highlighting, but also because it enables Vim to correctly recognise closing parentheses and brackets. This makes hacking Autoconf way easier, since I can quickly verify opening/closing brackets and parentheses using the % char.

Well, that was just my opinion. Now it's up to you. You're way more active on changing configure than me :-)

erlend-aasland commented Jun 6, 2023

Copy link
Copy Markdown
Contributor Author

Now it's up to you. You're way more active on changing configure than me :-)

Thanks for you input. I'll abide with Dong-hee's final word on this :)

I won't repeat my arguments as to why I think this is worth it (see #105226 (comment)), but (surprise, surprise) I still would like to land this :) An alternative could be to make sure strings including # are not followed by a closing bracket (quote) on the same line, however such a PR will introduce a larger diff to configure.ac, and it will also introduce changes to the generated configure file; I don't think that alternative is a better choice. This PR was designed to not alter the generated configure file, in order to keep the amount of churn to a minimum. IMO, it is an improvement to status quo.

corona10 approved these changes Jun 7, 2023
View reviewed changes

corona10 left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

Okay, let's go.
From my conservative view it is +0.5.. but doing something is always better than doing nothing.
Someone may complain but soon adapt to a new convention.

erlend-aasland commented Jun 7, 2023

Copy link
Copy Markdown
Contributor Author

Someone may complain but soon adapt to a new convention.

As I said in #105226 (comment), there is already precedent for using quadrigraphs in configure.ac (we already do for stuff like brackets) ;)

Thanks, both!

erlend-aasland changed the title gh-89886: Use Autoconf quadrigraphs to fix syntax highlighting gh-89886: Use Autoconf quadrigraphs where appropriate Jun 7, 2023
erlend-aasland merged commit 27c68a6 into python:main Jun 7, 2023

miss-islington commented Jun 7, 2023

Copy link
Copy Markdown
Contributor

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington commented Jun 7, 2023

Copy link
Copy Markdown
Contributor

Sorry @erlend-aasland, I had trouble checking out the 3.12 backport branch.
Please retry by removing and re-adding the "needs backport to 3.12" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker 27c68a6d8f20090310450862c2c299bb7ba3c160 3.12

erlend-aasland deleted the autoconf/quadrigraphs branch June 7, 2023 07:11
erlend-aasland added a commit to erlend-aasland/cpython that referenced this pull request Jun 7, 2023
[3.12] pythongh-89886: Use Autoconf quadrigraphs where appropriate (p… …
879bb67
…ython#105226)

bedevere-bot commented Jun 7, 2023

Copy link
Copy Markdown

GH-105423 is a backport of this pull request to the 3.12 branch.

bedevere-bot removed the needs backport to 3.12 only security fixes label Jun 7, 2023
erlend-aasland added a commit that referenced this pull request Jun 7, 2023
[3.12] gh-89886: Use Autoconf quadrigraphs where appropriate (#105226) ( …
c607551
#105423)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

vstinner vstinner left review comments
corona10 corona10 approved these changes

Assignees

erlend-aasland

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Footer

© 2026 GitHub, Inc.