Sorry, something went wrong.
|
Changes must be communicated; we need a NEWS entry and a bullet in What's New. |
Sorry, something went wrong.
Sorry, something went wrong.
|
Yes. It is not surprising that the generated output changes considerably when you switch from one generator to another. |
Sorry, something went wrong.
There was a problem hiding this comment.
It looks fine to me, but I am far from an autoconf expert.
Sorry, something went wrong.
|
Thanks for the reviews! I'll have another look myself, before landing. Also, I'll add NEWS/What's New items. |
Sorry, something went wrong.
|
IIUC, Autoconf macros are now pickier wrt. quoting than before; let's keep that in mind if we might get syntax errors for some untested configure options. Also with that in mind, it may make sense to do a macro audit and simply add proper quoting to all arguments. EDIT: Fixed in gh-105062 |
Sorry, something went wrong.
|
Running autoupdate (2.71) on configure.ac asks us to fix sys/time.h dependency: $ autoupdate configure.ac
configure.ac:5246: warning: Update your code to rely only on HAVE_SYS_TIME_H,
then remove this warning and the obsolete code below it.
All current systems provide time.h; it need not be checked for.
Not all systems provide sys/time.h, but those that do, all allow
you to include it and time.h simultaneously.
It's an easy fix, and I suggest we apply it in a follow-up PR. EDIT: Fixed in gh-105058 |
Sorry, something went wrong.
|
FTR, I'm landing this later today. (The Hypothesis failure is a known issue.) |
Sorry, something went wrong.
|
Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. |
Sorry, something went wrong.
|
Sorry, @erlend-aasland, I could not cleanly backport this to 3.12 due to a conflict. |
Sorry, something went wrong.
|
GH-105207 is a backport of this pull request to the 3.12 branch. |
Sorry, something went wrong.
⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️Hi! The buildbot s390x RHEL7 3.x has failed when building commit 8a8ebf2. What do you need to do:
You can take a look at the buildbot page here: https://buildbot.python.org/all/#builders/179/builds/4667 Failed tests:
Failed subtests:
Summary of the results of the build (if available): == Tests result: FAILURE then FAILURE == 424 tests OK. 10 slowest tests:
1 test failed: 22 tests skipped: 1 re-run test: Total duration: 7 min 26 sec Click to see traceback logsTraceback (most recent call last):
File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z/build/Lib/test/test_cppext.py", line 22, in test_build_cpp11
self.check_build(False, '_testcpp11ext')
File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z/build/Lib/test/test_cppext.py", line 40, in check_build
self._check_build(std_cpp03, extension_name, python_exe)
File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z/build/Lib/test/test_cppext.py", line 69, in _check_build
run_cmd('Install', cmd)
File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z/build/Lib/test/test_cppext.py", line 53, in run_cmd
subprocess.run(cmd, check=True, env=env)
File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z/build/Lib/subprocess.py", line 571, in run
raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z/build/build/test_python_57110æ/tempcwd/env/bin/python', '-X', 'dev', '-m', 'pip', 'install', '--no-build-isolation', '/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z/build/build/test_python_57110æ/tempcwd/pkg']' returned non-zero exit status 1.
Traceback (most recent call last):
File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z/build/Lib/test/test_cppext.py", line 25, in test_build_cpp03
self.check_build(True, '_testcpp03ext')
File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z/build/Lib/test/test_cppext.py", line 40, in check_build
self._check_build(std_cpp03, extension_name, python_exe)
File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z/build/Lib/test/test_cppext.py", line 69, in _check_build
run_cmd('Install', cmd)
File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z/build/Lib/test/test_cppext.py", line 53, in run_cmd
subprocess.run(cmd, check=True, env=env)
File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z/build/Lib/subprocess.py", line 571, in run
raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z/build/build/test_python_57110æ/tempcwd/env/bin/python', '-X', 'dev', '-m', 'pip', 'install', '--no-build-isolation', '/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z/build/build/test_python_57110æ/tempcwd/pkg']' returned non-zero exit status 1.
Traceback (most recent call last):
File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z/build/Lib/test/test_cppext.py", line 25, in test_build_cpp03
self.check_build(True, '_testcpp03ext')
File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z/build/Lib/test/test_cppext.py", line 40, in check_build
self._check_build(std_cpp03, extension_name, python_exe)
File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z/build/Lib/test/test_cppext.py", line 69, in _check_build
run_cmd('Install', cmd)
File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z/build/Lib/test/test_cppext.py", line 53, in run_cmd
subprocess.run(cmd, check=True, env=env)
File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z/build/Lib/subprocess.py", line 571, in run
raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z/build/build/test_python_57110æ/test_python_worker_64741æ/tempcwd/env/bin/python', '-X', 'dev', '-m', 'pip', 'install', '--no-build-isolation', '/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z/build/build/test_python_57110æ/test_python_worker_64741æ/tempcwd/pkg']' returned non-zero exit status 1.
Traceback (most recent call last):
File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z/build/Lib/test/test_cppext.py", line 22, in test_build_cpp11
self.check_build(False, '_testcpp11ext')
File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z/build/Lib/test/test_cppext.py", line 40, in check_build
self._check_build(std_cpp03, extension_name, python_exe)
File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z/build/Lib/test/test_cppext.py", line 69, in _check_build
run_cmd('Install', cmd)
File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z/build/Lib/test/test_cppext.py", line 53, in run_cmd
subprocess.run(cmd, check=True, env=env)
File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z/build/Lib/subprocess.py", line 571, in run
raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z/build/build/test_python_57110æ/test_python_worker_64741æ/tempcwd/env/bin/python', '-X', 'dev', '-m', 'pip', 'install', '--no-build-isolation', '/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z/build/build/test_python_57110æ/test_python_worker_64741æ/tempcwd/pkg']' returned non-zero exit status 1.
|
Sorry, something went wrong.
⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️Hi! The buildbot s390x RHEL7 LTO 3.12 has failed when building commit 83c7386. What do you need to do:
You can take a look at the buildbot page here: https://buildbot.python.org/all/#builders/1163/builds/46 Failed tests:
Failed subtests:
Summary of the results of the build (if available): == Tests result: FAILURE then FAILURE == 441 tests OK. 10 slowest tests:
1 test failed: 25 tests skipped: 1 re-run test: Total duration: 7 min 31 sec Click to see traceback logsTraceback (most recent call last):
File "/home/dje/cpython-buildarea/3.12.edelsohn-rhel-z.lto/build/Lib/test/test_cppext.py", line 25, in test_build_cpp03
self.check_build(True, '_testcpp03ext')
File "/home/dje/cpython-buildarea/3.12.edelsohn-rhel-z.lto/build/Lib/test/test_cppext.py", line 40, in check_build
self._check_build(std_cpp03, extension_name)
File "/home/dje/cpython-buildarea/3.12.edelsohn-rhel-z.lto/build/Lib/test/test_cppext.py", line 94, in _check_build
run_cmd('Install', cmd)
File "/home/dje/cpython-buildarea/3.12.edelsohn-rhel-z.lto/build/Lib/test/test_cppext.py", line 72, in run_cmd
subprocess.run(cmd, check=True, env=env)
File "/home/dje/cpython-buildarea/3.12.edelsohn-rhel-z.lto/build/Lib/subprocess.py", line 571, in run
raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['env/bin/python', '-X', 'dev', '-m', 'pip', 'install', '--no-build-isolation', '/home/dje/cpython-buildarea/3.12.edelsohn-rhel-z.lto/build/build/test_python_34304æ/tempcwd/pkg']' returned non-zero exit status 1.
Traceback (most recent call last):
File "/home/dje/cpython-buildarea/3.12.edelsohn-rhel-z.lto/build/Lib/test/test_cppext.py", line 25, in test_build_cpp03
self.check_build(True, '_testcpp03ext')
File "/home/dje/cpython-buildarea/3.12.edelsohn-rhel-z.lto/build/Lib/test/test_cppext.py", line 40, in check_build
self._check_build(std_cpp03, extension_name)
File "/home/dje/cpython-buildarea/3.12.edelsohn-rhel-z.lto/build/Lib/test/test_cppext.py", line 94, in _check_build
run_cmd('Install', cmd)
File "/home/dje/cpython-buildarea/3.12.edelsohn-rhel-z.lto/build/Lib/test/test_cppext.py", line 72, in run_cmd
subprocess.run(cmd, check=True, env=env)
File "/home/dje/cpython-buildarea/3.12.edelsohn-rhel-z.lto/build/Lib/subprocess.py", line 571, in run
raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['env/bin/python', '-X', 'dev', '-m', 'pip', 'install', '--no-build-isolation', '/home/dje/cpython-buildarea/3.12.edelsohn-rhel-z.lto/build/build/test_python_34304æ/test_python_worker_41932æ/tempcwd/pkg']' returned non-zero exit status 1.
Traceback (most recent call last):
File "/home/dje/cpython-buildarea/3.12.edelsohn-rhel-z.lto/build/Lib/test/test_cppext.py", line 22, in test_build_cpp11
self.check_build(False, '_testcpp11ext')
File "/home/dje/cpython-buildarea/3.12.edelsohn-rhel-z.lto/build/Lib/test/test_cppext.py", line 40, in check_build
self._check_build(std_cpp03, extension_name)
File "/home/dje/cpython-buildarea/3.12.edelsohn-rhel-z.lto/build/Lib/test/test_cppext.py", line 94, in _check_build
run_cmd('Install', cmd)
File "/home/dje/cpython-buildarea/3.12.edelsohn-rhel-z.lto/build/Lib/test/test_cppext.py", line 72, in run_cmd
subprocess.run(cmd, check=True, env=env)
File "/home/dje/cpython-buildarea/3.12.edelsohn-rhel-z.lto/build/Lib/subprocess.py", line 571, in run
raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['env/bin/python', '-X', 'dev', '-m', 'pip', 'install', '--no-build-isolation', '/home/dje/cpython-buildarea/3.12.edelsohn-rhel-z.lto/build/build/test_python_34304æ/tempcwd/pkg']' returned non-zero exit status 1.
Traceback (most recent call last):
File "/home/dje/cpython-buildarea/3.12.edelsohn-rhel-z.lto/build/Lib/test/test_cppext.py", line 22, in test_build_cpp11
self.check_build(False, '_testcpp11ext')
File "/home/dje/cpython-buildarea/3.12.edelsohn-rhel-z.lto/build/Lib/test/test_cppext.py", line 40, in check_build
self._check_build(std_cpp03, extension_name)
File "/home/dje/cpython-buildarea/3.12.edelsohn-rhel-z.lto/build/Lib/test/test_cppext.py", line 94, in _check_build
run_cmd('Install', cmd)
File "/home/dje/cpython-buildarea/3.12.edelsohn-rhel-z.lto/build/Lib/test/test_cppext.py", line 72, in run_cmd
subprocess.run(cmd, check=True, env=env)
File "/home/dje/cpython-buildarea/3.12.edelsohn-rhel-z.lto/build/Lib/subprocess.py", line 571, in run
raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['env/bin/python', '-X', 'dev', '-m', 'pip', 'install', '--no-build-isolation', '/home/dje/cpython-buildarea/3.12.edelsohn-rhel-z.lto/build/build/test_python_34304æ/test_python_worker_41932æ/tempcwd/pkg']' returned non-zero exit status 1.
|
Sorry, something went wrong.
⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️Hi! The buildbot PPC64 Fedora 3.12 has failed when building commit 83c7386. What do you need to do:
You can take a look at the buildbot page here: https://buildbot.python.org/all/#builders/1202/builds/53 Failed tests:
Failed subtests:
Summary of the results of the build (if available): == Tests result: FAILURE then FAILURE == 441 tests OK. 10 slowest tests:
1 test failed: 25 tests skipped: 1 re-run test: Total duration: 1 hour 15 min Click to see traceback logsTraceback (most recent call last):
File "/home/shager/cpython-buildarea/3.12.edelsohn-fedora-ppc64/build/Lib/test/test_cppext.py", line 25, in test_build_cpp03
self.check_build(True, '_testcpp03ext')
File "/home/shager/cpython-buildarea/3.12.edelsohn-fedora-ppc64/build/Lib/test/test_cppext.py", line 40, in check_build
self._check_build(std_cpp03, extension_name)
File "/home/shager/cpython-buildarea/3.12.edelsohn-fedora-ppc64/build/Lib/test/test_cppext.py", line 94, in _check_build
run_cmd('Install', cmd)
File "/home/shager/cpython-buildarea/3.12.edelsohn-fedora-ppc64/build/Lib/test/test_cppext.py", line 72, in run_cmd
subprocess.run(cmd, check=True, env=env)
File "/home/shager/cpython-buildarea/3.12.edelsohn-fedora-ppc64/build/Lib/subprocess.py", line 571, in run
raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['env/bin/python', '-X', 'dev', '-m', 'pip', 'install', '--no-build-isolation', '/home/shager/cpython-buildarea/3.12.edelsohn-fedora-ppc64/build/build_oot/build/test_python_63283æ/tempcwd/pkg']' returned non-zero exit status 1.
Traceback (most recent call last):
File "/home/shager/cpython-buildarea/3.12.edelsohn-fedora-ppc64/build/Lib/test/test_cppext.py", line 22, in test_build_cpp11
self.check_build(False, '_testcpp11ext')
File "/home/shager/cpython-buildarea/3.12.edelsohn-fedora-ppc64/build/Lib/test/test_cppext.py", line 40, in check_build
self._check_build(std_cpp03, extension_name)
File "/home/shager/cpython-buildarea/3.12.edelsohn-fedora-ppc64/build/Lib/test/test_cppext.py", line 94, in _check_build
run_cmd('Install', cmd)
File "/home/shager/cpython-buildarea/3.12.edelsohn-fedora-ppc64/build/Lib/test/test_cppext.py", line 72, in run_cmd
subprocess.run(cmd, check=True, env=env)
File "/home/shager/cpython-buildarea/3.12.edelsohn-fedora-ppc64/build/Lib/subprocess.py", line 571, in run
raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['env/bin/python', '-X', 'dev', '-m', 'pip', 'install', '--no-build-isolation', '/home/shager/cpython-buildarea/3.12.edelsohn-fedora-ppc64/build/build_oot/build/test_python_63283æ/tempcwd/pkg']' returned non-zero exit status 1.
Traceback (most recent call last):
File "/home/shager/cpython-buildarea/3.12.edelsohn-fedora-ppc64/build/Lib/test/test_cppext.py", line 22, in test_build_cpp11
self.check_build(False, '_testcpp11ext')
File "/home/shager/cpython-buildarea/3.12.edelsohn-fedora-ppc64/build/Lib/test/test_cppext.py", line 40, in check_build
self._check_build(std_cpp03, extension_name)
File "/home/shager/cpython-buildarea/3.12.edelsohn-fedora-ppc64/build/Lib/test/test_cppext.py", line 94, in _check_build
run_cmd('Install', cmd)
File "/home/shager/cpython-buildarea/3.12.edelsohn-fedora-ppc64/build/Lib/test/test_cppext.py", line 72, in run_cmd
subprocess.run(cmd, check=True, env=env)
File "/home/shager/cpython-buildarea/3.12.edelsohn-fedora-ppc64/build/Lib/subprocess.py", line 571, in run
raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['env/bin/python', '-X', 'dev', '-m', 'pip', 'install', '--no-build-isolation', '/home/shager/cpython-buildarea/3.12.edelsohn-fedora-ppc64/build/build_oot/build/test_python_63283æ/test_python_worker_2510æ/tempcwd/pkg']' returned non-zero exit status 1.
Traceback (most recent call last):
File "/home/shager/cpython-buildarea/3.12.edelsohn-fedora-ppc64/build/Lib/test/test_cppext.py", line 25, in test_build_cpp03
self.check_build(True, '_testcpp03ext')
File "/home/shager/cpython-buildarea/3.12.edelsohn-fedora-ppc64/build/Lib/test/test_cppext.py", line 40, in check_build
self._check_build(std_cpp03, extension_name)
File "/home/shager/cpython-buildarea/3.12.edelsohn-fedora-ppc64/build/Lib/test/test_cppext.py", line 94, in _check_build
run_cmd('Install', cmd)
File "/home/shager/cpython-buildarea/3.12.edelsohn-fedora-ppc64/build/Lib/test/test_cppext.py", line 72, in run_cmd
subprocess.run(cmd, check=True, env=env)
File "/home/shager/cpython-buildarea/3.12.edelsohn-fedora-ppc64/build/Lib/subprocess.py", line 571, in run
raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['env/bin/python', '-X', 'dev', '-m', 'pip', 'install', '--no-build-isolation', '/home/shager/cpython-buildarea/3.12.edelsohn-fedora-ppc64/build/build_oot/build/test_python_63283æ/test_python_worker_2510æ/tempcwd/pkg']' returned non-zero exit status 1.
|
Sorry, something went wrong.
|
FTR, I'm investigating the buildbot errors. |
Sorry, something went wrong.
|
GH-105469 is a backport of this pull request to the 3.11 branch. |
Sorry, something went wrong.
Based on gh-29756