← 返回首页
[3.12] gh-104825: add omitted idlelib text fix by terryjreedy · Pull Request #104880 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
Resetting focus

[3.12] gh-104825: add omitted idlelib text fix#104880

Merged
pablogsal merged 1 commit into
python:3.12from
terryjreedy:toktest312
May 24, 2023
Merged

[3.12] gh-104825: add omitted idlelib text fix#104880
pablogsal merged 1 commit into
python:3.12from
terryjreedy:toktest312

Conversation

terryjreedy commented May 24, 2023
edited
Loading

Copy link
Copy Markdown
Member

Order of events:
Terry automerged new idlelib test into main.
Ms. I. made a 3.12 backport; tests passed.
Pablo merged the tokenize change with idlelib test fix into main. Pablo merged a 3.12 backport without the idle test fix as the backport of the latter had not yet been been merged. Terry merged the idlelib test backport. The new test failed on at least 4 3.12 buildbots because of the tokenize change. This PR backports the now needed idlelib test fix.

(cherry picked from commit c8cf9b4)

Order of events: Terry merged new idlelib test into main. Ms. I. made a 3.12 backport; tests passed. Pablo merged the tokenize change with idlelib test fix into main. Pablo merged a 3.12 backport without the idle test fix as the backport of the latter had not yet been been merged. Terry merged the idlelib test backport. The new test failed on at least 4 3.12 buildbots because of the tokenize change. This PR backports the now needed idlelib test fix. (cherry picked from commit c8cf9b4)

Copy link
Copy Markdown
Member

Thanks a lot @terryjreedy !

pablogsal enabled auto-merge (squash) May 24, 2023 17:31
pablogsal merged commit 2b54ea5 into python:3.12 May 24, 2023
terryjreedy deleted the toktest312 branch May 24, 2023 17:47

Copy link
Copy Markdown
Member Author

This would not have happened if Address Sanitizer test had not been disabled.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip news tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Footer

© 2026 GitHub, Inc.