← 返回首页
gh-102856: Update "Formatted string literals" docs section after PEP701 by lysnikolaou · Pull Request #104861 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

gh-102856: Update "Formatted string literals" docs section after PEP701#104861

Merged
lysnikolaou merged 1 commit into
python:mainfrom
lysnikolaou:lexical-analysis-pep701
May 24, 2023
Merged

gh-102856: Update "Formatted string literals" docs section after PEP701#104861
lysnikolaou merged 1 commit into
python:mainfrom
lysnikolaou:lexical-analysis-pep701

Conversation

lysnikolaou commented May 24, 2023 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

bedevere-bot mentioned this pull request May 24, 2023
Closed
4 tasks
bedevere-bot added docs Documentation in the Doc dir skip news labels May 24, 2023
lysnikolaou requested a review from pablogsal May 24, 2023 12:13

pablogsal commented May 24, 2023

Copy link
Copy Markdown
Member

I think we need to fix also the "grammar" that is included here and substitute that for the PEG grammar

pablogsal commented May 24, 2023

Copy link
Copy Markdown
Member

I mean this one

lysnikolaou commented May 24, 2023

Copy link
Copy Markdown
Member Author

I think we need to fix also the "grammar" that is included here and substitute that for the PEG grammar

Not sure about that. The existing grammar feels easier to read. Since the purpose of this is to give an overview of what can go into an f-string, I don't think we should over-complicate stuff with FSTRING_START, FSTRING_END etc.

pablogsal commented May 24, 2023

Copy link
Copy Markdown
Member

Hummmm IIRC that grammar is slightly incorrect or it was missing some details. Check it out and if you are happy with it then let's keep it

lysnikolaou commented May 24, 2023

Copy link
Copy Markdown
Member Author

I briefly compared it with our version in the PEG and it seems okay to me. If you're also okay with it, we can merge.

pablogsal approved these changes May 24, 2023
View reviewed changes

pablogsal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

LGTM

Great work!

lysnikolaou added the needs backport to 3.12 only security fixes label May 24, 2023
lysnikolaou merged commit 8e5b3b9 into python:main May 24, 2023

miss-islington commented May 24, 2023

Copy link
Copy Markdown
Contributor

Thanks @lysnikolaou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 24, 2023
pythongh-102856: Update "Formatted string literals" docs section afte… …
e867088
…r PEP701 (pythonGH-104861) (cherry picked from commit 8e5b3b9) Co-authored-by: Lysandros Nikolaou <lisandrosnik@gmail.com>

bedevere-bot commented May 24, 2023

Copy link
Copy Markdown

GH-104865 is a backport of this pull request to the 3.12 branch.

bedevere-bot removed the needs backport to 3.12 only security fixes label May 24, 2023
lysnikolaou added a commit that referenced this pull request May 24, 2023
[3.12] gh-102856: Update "Formatted string literals" docs section aft… …
25890eb
…er PEP701 (GH-104861) (#104865) (cherry picked from commit 8e5b3b9) Co-authored-by: Lysandros Nikolaou <lisandrosnik@gmail.com>
erlend-aasland mentioned this pull request Jun 6, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

pablogsal pablogsal approved these changes

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Footer

© 2026 GitHub, Inc.