← 返回首页
gh-102856: Add missing quote to fix doctest by hugovk · Pull Request #104852 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

gh-102856: Add missing quote to fix doctest#104852

Merged
hugovk merged 1 commit into
python:mainfrom
hugovk:fix-docs
May 24, 2023
Merged

gh-102856: Add missing quote to fix doctest#104852
hugovk merged 1 commit into
python:mainfrom
hugovk:fix-docs

Conversation

hugovk commented May 24, 2023 •
edited
Loading

Copy link
Copy Markdown
Member
Document: whatsnew/3.12 ----------------------- ********************************************************************** File "whatsnew/3.12.rst", line ?, in default Failed example: f"This is the playlist: {", ".join(songs)}" Expected: 'This is the playlist: Take me back to Eden, Alkaline, Ascensionism Got: 'This is the playlist: Take me back to Eden, Alkaline, Ascensionism' ********************************************************************** 1 items had failures: 1 of 12 in default 12 tests in 1 items. 11 passed and 1 failed. ***Test Failed*** 1 failures.

https://github.com/python/cpython/actions/runs/5066957137/jobs/9097400760

Introduced in #104824.

bedevere-bot added awaiting core review docs Documentation in the Doc dir skip news labels May 24, 2023
hugovk changed the title Add missing quote to fix doctest gh-102856: Add missing quote to fix doctest May 24, 2023
bedevere-bot mentioned this pull request May 24, 2023
Closed
4 tasks
hugovk added the needs backport to 3.12 only security fixes label May 24, 2023
This was referenced May 24, 2023
Merged
Merged
hugovk merged commit 3e97c00 into python:main May 24, 2023
hugovk deleted the fix-docs branch May 24, 2023 10:21

miss-islington commented May 24, 2023

Copy link
Copy Markdown
Contributor

Thanks @hugovk for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 24, 2023
pythongh-102856: Add missing quote to fix doctest (pythonGH-104852) …
ec62b10
(cherry picked from commit 3e97c00) Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>

bedevere-bot commented May 24, 2023

Copy link
Copy Markdown

GH-104854 is a backport of this pull request to the 3.12 branch.

bedevere-bot removed the needs backport to 3.12 only security fixes label May 24, 2023
hugovk added a commit that referenced this pull request May 24, 2023
[3.12] gh-102856: Add missing quote to fix doctest (GH-104852) (#104854) …
2d685ec
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
erlend-aasland mentioned this pull request Jun 6, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

AlexWaygood AlexWaygood approved these changes

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Footer

© 2026 GitHub, Inc.