← 返回首页
[3.12] gh-104341: Add a Separate "Running" Lock for Each Thread (gh-104754) by miss-islington · Pull Request #104817 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
Resetting focus

[3.12] gh-104341: Add a Separate "Running" Lock for Each Thread (gh-104754)#104817

Closed
miss-islington wants to merge 1 commit into
python:3.12from
miss-islington:backport-097b783-3.12
Closed

[3.12] gh-104341: Add a Separate "Running" Lock for Each Thread (gh-104754)#104817
miss-islington wants to merge 1 commit into
python:3.12from
miss-islington:backport-097b783-3.12

Conversation

Copy link
Copy Markdown
Contributor

Having a separate lock means Thread.join() doesn't need to wait for the thread to be cleaned up first. It can wait for the thread's Python target to finish running. This gives us some flexibility in how we clean up threads.

(This is a minor cleanup as part of a fix for gh-104341.)
(cherry picked from commit 097b783)

Co-authored-by: Eric Snow ericsnowcurrently@gmail.com

…ngh-104754) Having a separate lock means Thread.join() doesn't need to wait for the thread to be cleaned up first. It can wait for the thread's Python target to finish running. This gives us some flexibility in how we clean up threads. (This is a minor cleanup as part of a fix for pythongh-104341.) (cherry picked from commit 097b783) Co-authored-by: Eric Snow <ericsnowcurrently@gmail.com>

gpshead commented May 24, 2023

Copy link
Copy Markdown
Member

this broke main.

miss-islington deleted the backport-097b783-3.12 branch May 24, 2023 15:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Footer

© 2026 GitHub, Inc.