← 返回首页
gh-99108: Refresh HACL* by msprotz · Pull Request #104808 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

gh-99108: Refresh HACL*#104808

Merged
gpshead merged 3 commits into
python:mainfrom
msprotz:protz_hacl_refresh
May 24, 2023
Merged

gh-99108: Refresh HACL*#104808
gpshead merged 3 commits into
python:mainfrom
msprotz:protz_hacl_refresh

Conversation

msprotz commented May 23, 2023 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

There have been a few important upstream changes in HACL* that I'd like to bring in, and hopefully backport to the 3.12 branch.

FYI SHA3 is also being integrated into NSS as we speak, hence the active upstream development on making things better.

msprotz requested review from a team and tiran as code owners May 23, 2023 19:04
bedevere-bot mentioned this pull request May 23, 2023
Closed

msprotz commented May 23, 2023

Copy link
Copy Markdown
Contributor Author

@gpshead let me know if you'd like a NEWS entry or not. Thanks!

gpshead added the needs backport to 3.12 only security fixes label May 24, 2023

gpshead commented May 24, 2023

Copy link
Copy Markdown
Member

I'd still add a NEWS entry as it is an observable change and a potential bugfix: Something like Refresh our new HACL* built-in :mod:`hashlib` code from upstream. Built-in SHA2 should be faster and an issue with SHA3 on 32-bit platforms is fixed.

gpshead self-assigned this May 24, 2023
gpshead merged commit 160321e into python:main May 24, 2023

miss-islington commented May 24, 2023

Copy link
Copy Markdown
Contributor

Thanks @msprotz for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 24, 2023
pythongh-99108: Refresh HACL* (pythonGH-104808) …
b50d6c1
Refresh HACL* from upstream to improve SHA2 performance and fix a 32-bit issue in SHA3. (cherry picked from commit 160321e) Co-authored-by: Jonathan Protzenko <protz@microsoft.com>

bedevere-bot commented May 24, 2023

Copy link
Copy Markdown

GH-104893 is a backport of this pull request to the 3.12 branch.

bedevere-bot removed the needs backport to 3.12 only security fixes label May 24, 2023
gpshead pushed a commit that referenced this pull request May 24, 2023
[3.12] gh-99108: Refresh HACL* (GH-104808) (#104893) …
c4bc97a
gh-99108: Refresh HACL* (GH-104808) Refresh HACL* from upstream to improve SHA2 performance and fix a 32-bit issue in SHA3. (cherry picked from commit 160321e) Co-authored-by: Jonathan Protzenko <protz@microsoft.com>
erlend-aasland mentioned this pull request Jun 6, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

gpshead gpshead approved these changes
tiran Awaiting requested review from tiran

Assignees

gpshead

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Footer

© 2026 GitHub, Inc.