← 返回首页
gh-104719: IDLE - test existence of all tokenize references. by terryjreedy · Pull Request #104767 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

gh-104719: IDLE - test existence of all tokenize references.#104767

Merged
terryjreedy merged 14 commits into
python:mainfrom
terryjreedy:toktest
May 24, 2023
Merged

gh-104719: IDLE - test existence of all tokenize references.#104767
terryjreedy merged 14 commits into
python:mainfrom
terryjreedy:toktest

Conversation

terryjreedy commented May 22, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

This was prompted when (temporary) removal of tokenize.tabsize broke IDLE without a CI failure.
Class editor.IndentSearcher contains all editor references to the tokenize module.
The 2 iomenu references cover those in pyshell, run, and runscript also.

terryjreedy self-assigned this May 22, 2023
bedevere-bot mentioned this pull request May 22, 2023
Closed
JelleZijlstra reviewed May 23, 2023
View reviewed changes
Comment thread Lib/idlelib/editor.py Outdated Show resolved Hide resolved
Comment thread Lib/idlelib/idle_test/test_iomenu.py Outdated Show resolved Hide resolved
terryjreedy and others added 2 commits May 23, 2023 01:06
Update Lib/idlelib/editor.py …
c6f59fb
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Update Lib/idlelib/idle_test/test_iomenu.py …
0a99cf0
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
terryjreedy added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes and removed topic-IDLE labels May 23, 2023
terryjreedy enabled auto-merge (squash) May 23, 2023 21:34

terryjreedy commented May 24, 2023

Copy link
Copy Markdown
Member Author

@Yhg1s Can you as RM merge this? Address sanitizer had failed 4 times in a row because test_hashlib, test_importlib, and test_threading (X3) have altered the environment. Details on discord core-workflow. (Will rerun again

terryjreedy merged commit e561c09 into python:main May 24, 2023

miss-islington commented May 24, 2023

Copy link
Copy Markdown
Contributor

Thanks @terryjreedy for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 24, 2023
pythongh-104719: IDLE - test existence of all tokenize references. (p… …
1061d30
…ythonGH-104767) Class editor.IndentSearcher contains all editor references to tokenize module. Module io tokenize reference cover those other modules. (cherry picked from commit e561c09) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu> Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>

bedevere-bot commented May 24, 2023

Copy link
Copy Markdown

GH-104844 is a backport of this pull request to the 3.12 branch.

bedevere-bot removed the needs backport to 3.12 only security fixes label May 24, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 24, 2023
pythongh-104719: IDLE - test existence of all tokenize references. (p… …
63336e2
…ythonGH-104767) Class editor.IndentSearcher contains all editor references to tokenize module. Module io tokenize reference cover those other modules. (cherry picked from commit e561c09) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu> Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>

bedevere-bot commented May 24, 2023

Copy link
Copy Markdown

GH-104845 is a backport of this pull request to the 3.11 branch.

bedevere-bot removed the needs backport to 3.11 only security fixes label May 24, 2023
terryjreedy added a commit that referenced this pull request May 24, 2023
[3.12] gh-104719: IDLE - test existence of all tokenize references. (G… …
5e1799e
…H-104767) (#104844) gh-104719: IDLE - test existence of all tokenize references. (GH-104767) Class editor.IndentSearcher contains all editor references to tokenize module. Module io tokenize reference cover those other modules. (cherry picked from commit e561c09) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu> Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
terryjreedy added a commit that referenced this pull request May 24, 2023
[3.11] gh-104719: IDLE - test existence of all tokenize references. (G… …
22618a8
…H-104767) (#104845) gh-104719: IDLE - test existence of all tokenize references. (GH-104767) Class editor.IndentSearcher contains all editor references to tokenize module. Module io tokenize reference cover those other modules. (cherry picked from commit e561c09) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu> Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>

JelleZijlstra commented May 24, 2023

Copy link
Copy Markdown
Member

The buildbot failure might be a bad interaction with #104846 which @pablogsal merged earlier.

JelleZijlstra commented May 24, 2023

Copy link
Copy Markdown
Member

Oh, seems like Pablo already fixed this in his PR?

terryjreedy deleted the toktest branch May 24, 2023 13:34
python deleted a comment from bedevere-bot May 24, 2023
python deleted a comment from bedevere-bot May 24, 2023
python deleted a comment from bedevere-bot May 24, 2023
python deleted a comment from bedevere-bot May 24, 2023
terryjreedy mentioned this pull request May 24, 2023
Merged

terryjreedy commented May 24, 2023 •
edited
Loading

Copy link
Copy Markdown
Member Author

From #104880 message. "Order of events:
Terry automerged new idlelib test into main.
Ms. I. made a 3.12 backport; tests passed.
Pablo merged the tokenize change with idlelib test fix into main. Pablo merged a 3.12 backport without the idle test fix as the backport of the latter had not yet been been merged. Terry merged the idlelib test backport. The new test failed on at least 4 3.12 buildbots because of the tokenize change. This PR backports the now needed idlelib test fix."

erlend-aasland mentioned this pull request Jun 6, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

JelleZijlstra JelleZijlstra left review comments

Assignees

terryjreedy

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Footer

© 2026 GitHub, Inc.