← 返回首页
gh-104341: Fix threading Module Shutdown by ericsnowcurrently · Pull Request #104560 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

gh-104341: Fix threading Module Shutdown#104560

Draft
ericsnowcurrently wants to merge 12 commits into
python:mainfrom
ericsnowcurrently:fix-threading-module-shutdown
Draft

gh-104341: Fix threading Module Shutdown#104560
ericsnowcurrently wants to merge 12 commits into
python:mainfrom
ericsnowcurrently:fix-threading-module-shutdown

Conversation

ericsnowcurrently commented May 16, 2023 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

This should fix the frequent crashes in test_threading and test__xxsubinterpreters.

There is some duplication with the threading module which could be removed after this lands. We can also eliminate PyThreadState.on_delete and PyInterpreterState.threads.count, both of which are cases where the state of the threading module leaked out into the runtime.

(Also see gh-63008 and gh-18296.)

bedevere-bot mentioned this pull request May 16, 2023
Closed
ericsnowcurrently commented May 16, 2023
View reviewed changes
Comment thread Modules/_threadmodule.c Outdated
Comment on lines +86 to +92
PyThread_acquire_lock(threads->mutex, WAIT_LOCK);
while (threads->head != NULL) {
PyThread_release_lock(threads->mutex);
// XXX Sleep?
PyThread_acquire_lock(threads->mutex, WAIT_LOCK);
}
PyThread_release_lock(threads->mutex);

ericsnowcurrently May 16, 2023

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

FYI, this doesn't feel right. I'm going to look at what my options are. A condvar would work, but that doesn't seem to be something we do in CPython outside the GIL.

(I'm also open to ideas.)

ericsnowcurrently May 16, 2023

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

I've come up with a slightly better approach.

ericsnowcurrently added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 16, 2023

bedevere-bot commented May 16, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @ericsnowcurrently for commit 51d960e 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 16, 2023
adr26 reviewed May 16, 2023
View reviewed changes
Comment thread Modules/_threadmodule.c Outdated
static struct PyModuleDef thread_module;


/* threads owned by the modulo */

adr26 May 16, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

typo: module?

ericsnowcurrently May 16, 2023

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

fixed

ericsnowcurrently commented May 17, 2023

Copy link
Copy Markdown
Member Author

FTR, I ran the buildbots on commit 51d960e: https://buildbot.python.org/all/#/changes/22637.

ericsnowcurrently commented May 17, 2023 •
edited
Loading

Copy link
Copy Markdown
Member Author

Based on CI and the buildbots, I'm thinking there may be something wrong with this PR on macOS. I'll take a look.

Run failed when multiple fork-related tests timed out:

On the "x86-64 macOS PR" builder, the run was cancelled 3 times:

ericsnowcurrently commented May 17, 2023 •
edited
Loading

Copy link
Copy Markdown
Member Author

CI run 1

(https://github.com/python/cpython/actions/runs/4996253064/jobs/8949214929)

12 test modules failed before the CI job was canceled.

(details)

test module timed out after 20 minutes (1200s):

  • test_multiprocessing_main_handling (test_directory_compiled)
  • test_httpservers (test_accept)
  • test_fork1 (test_wait in fork_wait.py)
  • test_thread (test_forkinthread)
  • test_socketserver (test_forking_handled)
  • test_asyncio (test_fork_asyncio_run)
  • test_os (test_fork_warns_when_non_python_thread_exists)

individual tests timed out:

  • test.fork_wait.ForkWait.test_wait, via test_wait4 (300s)
  • test.test_wait4.Wait4Test.test_wait (30s)
  • test.test_tracemalloc.TestTracemallocEnabled.test_fork (300s)
  • test.test_pty.PtyTest.test_fork
  • test.test_pty.PtyTest.test_spawn_doesnt_hang
  • test.test_uuid.TestUUIDWithExtModule.testIssue8621 (300s)
  • test.test_uuid.TestUUIDWithoutExtModule.testIssue8621 (300s)
  • test.test_support.TestSupport.test_reap_children (30s)
  • test.test_support.TestSupport.test_temp_dir__forked_child (300s)

still running:

  • test_mailbox
  • test_wait3
  • test_tempfile
  • test_random

CI run 2

(https://github.com/python/cpython/actions/runs/4997616864/jobs/8952165246)

12 test modules failed before the CI job was canceled.

(details)

test module timed out after 20 minutes (1200s):

  • test_thread (test_forkinthread)
  • test_subprocess (test_close_fds_after_preexec)
  • test_concurrent_futures (tearDown)
  • test_builtin (test_input_no_stdout_fileno)
  • test_socketserver (test_forking_handled)
  • test_httpservers (test_accept)
  • test.test_asyncio.test_unix_events (test_fork_asyncio_run)

individual tests timed out:

  • test.fork_wait.ForkWait.test_wait, via test_wait3 (300s)
  • test.test_wait3.Wait3Test.test_wait (30s)
  • test.test_uuid.TestUUIDWithExtModule.testIssue8621 (300s)
  • test.test_uuid.TestUUIDWithoutExtModule.testIssue8621 (300s)
  • test.fork_wait.ForkWait.test_wait, via test_wait4 (300s)
  • test.test_wait4.Wait4Test.test_wait (30s)
  • test.test_pty.PtyTest.test_fork
  • test.test_logging.HandlerTest.test_post_fork_child_no_deadlock (300s)

still running:

  • test_multiprocessing_spawn
  • test_multiprocessing_main_handling
  • test_os
  • test_tempfile

Buildbot (ARM64 macOS PR)

(https://buildbot.python.org/all/#/builders/721/builds/1163/steps/5/logs/stdio)

25 test modules failed

(details)

test module timed out after 15 minutes (900s):

  • test_httpservers (test_accept)
  • test_threading (test_clear_threads_states_after_fork)
  • test_fork1 (test_wait in fork_wait.py)
  • test_concurrent_futures (test_duplicate_futures)
  • test_multiprocessing_spawn (test_context)
  • test_tempfile (test_noinherit)
  • test_socketserver (test_forking_handled)
  • test_os (test_fork_warns_when_non_python_thread_exists)
  • test_mailbox (test_lock_conflict)
  • test_subprocess (test_close_fds_after_preexec)
  • test_thread (test_forkinthread)
  • test.test_asyncio.test_unix_events (test_fork_asyncio_run)
  • test_multiprocessing_main_handling (test_directory)
  • test_builtin (test_input_no_stdout_fileno)
  • test_cmd_line (test_no_std_streams)
  • test_random (test_after_fork)
  • test_multiprocessing_forkserver (test_closefd)

individual tests timed out:

  • test.test_tracemalloc.TestTracemallocEnabled.test_fork (300s)
  • test.fork_wait.ForkWait.test_wait, via test_wait4 (300s)
  • test.test_wait4.Wait4Test.test_wait (30s)
  • test.test_support.TestSupport.test_reap_children (30s)
  • test.test_support.TestSupport.test_temp_dir__forked_child (300s)
  • test.fork_wait.ForkWait.test_wait, via test_wait3 (300s)
  • test.test_wait3.Wait3Test.test_wait (30s)
  • test.test_platform.PlatformTest.test_mac_ver_with_fork (300s)
  • test.test_pty.PtyTest.test_fork
  • test.test_pty.PtyTest.test_spawn_doesnt_hang
  • test.test_logging.HandlerTest.test_post_fork_child_no_deadlock (300s)
  • test.test_uuid.TestUUIDWithExtModule.testIssue8621 (300s)
  • test.test_uuid.TestUUIDWithoutExtModule.testIssue8621 (300s)

arhadthedev commented May 17, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

I reran the job and got the same result (the tests are not done yet but started to time out already).

ericsnowcurrently marked this pull request as draft May 18, 2023 16:57

github-actions Bot commented Apr 13, 2026

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

github-actions Bot added the stale Stale PR or inactive for long period of time. label Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

pitrou Awaiting requested review from pitrou
tim-one Awaiting requested review from tim-one
markshannon Awaiting requested review from markshannon
1 more reviewer
adr26 adr26 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

skip news stale Stale PR or inactive for long period of time.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Footer

© 2026 GitHub, Inc.