← 返回首页
gh-104523: inline minimal PGO rules by indygreg · Pull Request #104524 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

gh-104523: inline minimal PGO rules#104524

Merged
erlend-aasland merged 1 commit into
python:mainfrom
indygreg:build-pgo-rules-inline
May 16, 2023
Merged

gh-104523: inline minimal PGO rules#104524
erlend-aasland merged 1 commit into
python:mainfrom
indygreg:build-pgo-rules-inline

Conversation

indygreg commented May 16, 2023 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

Various rules were only ever invoked once and had minimal bodies. I don't see a benefit to the indirection.

So this commit inlines rules to simplify the PGO logic.

skip news

bedevere-bot mentioned this pull request May 16, 2023
Closed
pythongh-104523: inline minimal PGO rules …
dd66e38
Various rules were only ever invoked once and had minimal bodies. I don't see a benefit to the indirection. So this commit inlines rules to simplify the PGO logic. skip news (trivial, non-user-visible change)
indygreg force-pushed the build-pgo-rules-inline branch from 8eb0b50 to dd66e38 Compare May 16, 2023 01:48
erlend-aasland approved these changes May 16, 2023
View reviewed changes

erlend-aasland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

Makes sense. LGTM.

erlend-aasland commented May 16, 2023

Copy link
Copy Markdown
Contributor

(Hypothesis failure is unrelated to this PR.)

erlend-aasland merged commit 9084e1b into python:main May 16, 2023
carljm added a commit to carljm/cpython that referenced this pull request May 16, 2023
Merge branch 'main' into supermon …
a6dd626
* main: pythonGH-104510: Fix refleaks in `_io` base types (python#104516) pythongh-104539: Fix indentation error in logging.config.rst (python#104545) pythongh-104050: Don't star-import 'types' in Argument Clinic (python#104543) pythongh-104050: Add basic typing to CConverter in clinic.py (python#104538) pythongh-64595: Fix write file logic in Argument Clinic (python#104507) pythongh-104523: Inline minimal PGO rules (python#104524) pythongh-103861: Fix Zip64 extensions not being properly applied in some cases (python#103863) pythongh-69152: add method get_proxy_response_headers to HTTPConnection class (python#104248) pythongh-103763: Implement PEP 695 (python#103764) pythongh-104461: Run tkinter test_configure_screen on X11 only (pythonGH-104462) pythongh-104469: Convert _testcapi/watchers.c to use Argument Clinic (python#104503) pythongh-104482: Fix error handling bugs in ast.c (python#104483) pythongh-104341: Adjust tstate_must_exit() to Respect Interpreter Finalization (pythongh-104437) pythonGH-102613: Fix recursion error from `pathlib.Path.glob()` (pythonGH-104373)
zware reviewed May 16, 2023
View reviewed changes
Comment thread Makefile.pre.in Show resolved Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

zware zware left review comments
erlend-aasland erlend-aasland approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Footer

© 2026 GitHub, Inc.