← 返回首页
gh-64595: Fix write file logic in Argument Clinic by erlend-aasland · Pull Request #104507 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
Resetting focus

gh-64595: Fix write file logic in Argument Clinic#104507

Merged
erlend-aasland merged 2 commits into
python:mainfrom
erlend-aasland:clinic-dont-touch-everything
May 16, 2023
Merged

gh-64595: Fix write file logic in Argument Clinic#104507
erlend-aasland merged 2 commits into
python:mainfrom
erlend-aasland:clinic-dont-touch-everything

Conversation

erlend-aasland commented May 15, 2023
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

Check if any clinic output actually changes any of the output files
before deciding if we should touch the source file. This needs to be
done before we eventually update the source file.

Check if any clinic output actually changes any of the output files before deciding if we should touch the source file. This needs to be done before we eventually update the source file.

Copy link
Copy Markdown
Contributor Author

Alternative implementation (my preference) in 2a20f90.

erlend-aasland merged commit cca90b6 into python:main May 16, 2023
erlend-aasland deleted the clinic-dont-touch-everything branch May 16, 2023 10:25
carljm added a commit to carljm/cpython that referenced this pull request May 16, 2023
* main: pythonGH-104510: Fix refleaks in `_io` base types (python#104516) pythongh-104539: Fix indentation error in logging.config.rst (python#104545) pythongh-104050: Don't star-import 'types' in Argument Clinic (python#104543) pythongh-104050: Add basic typing to CConverter in clinic.py (python#104538) pythongh-64595: Fix write file logic in Argument Clinic (python#104507) pythongh-104523: Inline minimal PGO rules (python#104524) pythongh-103861: Fix Zip64 extensions not being properly applied in some cases (python#103863) pythongh-69152: add method get_proxy_response_headers to HTTPConnection class (python#104248) pythongh-103763: Implement PEP 695 (python#103764) pythongh-104461: Run tkinter test_configure_screen on X11 only (pythonGH-104462) pythongh-104469: Convert _testcapi/watchers.c to use Argument Clinic (python#104503) pythongh-104482: Fix error handling bugs in ast.c (python#104483) pythongh-104341: Adjust tstate_must_exit() to Respect Interpreter Finalization (pythongh-104437) pythonGH-102613: Fix recursion error from `pathlib.Path.glob()` (pythonGH-104373)
erlend-aasland added a commit to erlend-aasland/cpython that referenced this pull request Jul 5, 2023
ambv pushed a commit that referenced this pull request Jul 5, 2023
) Revert the two commits that introduced the regressions: - gh-104152 - gh-104507
erlend-aasland added a commit to erlend-aasland/cpython that referenced this pull request Jul 5, 2023
… Clinic (python#106449) Revert the two commits that introduced the regressions: - pythongh-104152 - pythongh-104507 (cherry picked from commit 9d1d4f9) Co-authored-by: Erlend Aasland <erlend@python.org>
erlend-aasland added a commit that referenced this pull request Jul 5, 2023
#106449) (#106452) Revert the two commits that introduced the regressions: - gh-104152 - gh-104507 (cherry picked from commit 9d1d4f9)

Copy link
Copy Markdown
Contributor Author

I'm going to do some more yak-shaving (#113317) before returning to this issue.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Footer

© 2026 GitHub, Inc.