Sorry, something went wrong.
|
FWIW this change builds up to a build system refactor that fixes some bugs/quirks with BOLT and enables the use of BOLT on libpython, which results in significant pyperformance impact. The remaining rough set of commits are available in #101093. |
Sorry, something went wrong.
There was a problem hiding this comment.
LGTM with nit comment
But for future work, I would like to say.
For the BOLT, it could also be able to be enabled without enabling PGO. (Might be a weird configuration, but someone may need it)
Sorry, something went wrong.
|
LGTM with nit comment But for future work, I would like to say. For the BOLT, it could also be able to be enabled without enabling PGO. (Might be a weird configuration, but someone may need it) Agree that we should support {none, either, both} configs. But it may require a bit of work to get there. I'll keep this in mind and try to implement it. I think the refactoring I'm doing to the PGO/BOLT make rules should make this vastly easier to achieve. |
Sorry, something went wrong.
⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️Hi! The buildbot wasm32-emscripten node (dynamic linking) 3.x has failed when building commit 27d8ecd. What do you need to do:
You can take a look at the buildbot page here: https://buildbot.python.org/all/#builders/1056/builds/2009 Failed tests:
Summary of the results of the build (if available): == Tests result: FAILURE == 335 tests OK. 10 slowest tests:
1 test failed: 127 tests skipped: Total duration: 25 min 49 sec Click to see traceback logsTraceback (most recent call last):
File "/opt/buildbot/bcannon-wasm/3.x.bcannon-wasm.emscripten-node-dl/build/Lib/test/string_tests.py", line 341, in test_find_periodic_pattern
self.checkequal(reference_find(p, text),
File "/opt/buildbot/bcannon-wasm/3.x.bcannon-wasm.emscripten-node-dl/build/Lib/test/string_tests.py", line 66, in checkequal
self.assertEqual(
AssertionError: -1 != 0
|
Sorry, something went wrong.
|
Post-merge review: LGTM @indygreg: please don't force-push; it does not play well with reviews on GitHub. If you haven't already, please take a look at the devguide, specifically Life of a Pull Request |
Sorry, something went wrong.
A future commit will make bolt's configure logic depend on PGO state. I'm moving the block in a standalone commit to make the diff easier to read.