← 返回首页
gh-91896: Fixup some docs issues following ByteString deprecation by AlexWaygood · Pull Request #104422 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

gh-91896: Fixup some docs issues following ByteString deprecation#104422

Merged
AlexWaygood merged 2 commits into
python:mainfrom
AlexWaygood:more-bytestring-deprecations
May 12, 2023
Merged

gh-91896: Fixup some docs issues following ByteString deprecation#104422
AlexWaygood merged 2 commits into
python:mainfrom
AlexWaygood:more-bytestring-deprecations

Conversation

AlexWaygood commented May 12, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

📚 Documentation preview 📚: https://cpython-previews--104422.org.readthedocs.build/

AlexWaygood requested a review from rhettinger as a code owner May 12, 2023 14:22
bedevere-bot mentioned this pull request May 12, 2023
Closed
bedevere-bot added the docs Documentation in the Doc dir label May 12, 2023
AlexWaygood changed the title gh-102500: Fixup some docs issues following ByteString deprecation gh-91896: Fixup some docs issues following ByteString deprecation May 12, 2023
bedevere-bot mentioned this pull request May 12, 2023
Closed
JelleZijlstra reviewed May 12, 2023
View reviewed changes
Comment thread Doc/whatsnew/3.12.rst Show resolved Hide resolved
Comment thread Doc/library/collections.abc.rst Show resolved Hide resolved
Update Doc/library/collections.abc.rst …
937ce5e
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
JelleZijlstra approved these changes May 12, 2023
View reviewed changes

JelleZijlstra left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

I'd like to get this merged so we can get CI green, but we should consider whether the import * case is important enough to drop the warning. This would be annoying:

% ./python.exe -Werr Python 3.12.0a7+ (heads/tvobject-dirty:bc3757969b, May 12 2023, 06:50:26) [Clang 14.0.0 (clang-1400.0.29.202)] on darwin Type "help", "copyright", "credits" or "license" for more information. >>> from typing import * Traceback (most recent call last): File "<stdin>", line 1, in <module> File "/Users/jelle/py/cpython/Lib/typing.py", line 3328, in __getattr__ warnings._deprecated("typing.ByteString", remove=(3, 14)) File "/Users/jelle/py/cpython/Lib/warnings.py", line 529, in _deprecated warn(msg, DeprecationWarning, stacklevel=3) DeprecationWarning: 'typing.ByteString' is deprecated and slated for removal in Python 3.14 >>>

AlexWaygood merged commit ce4eecf into python:main May 12, 2023
AlexWaygood mentioned this pull request May 12, 2023
Merged
carljm added a commit to carljm/cpython that referenced this pull request May 12, 2023
Merge branch 'main' into supermon …
8efd7c6
* main: pythongh-91896: Fixup some docs issues following ByteString deprecation (python#104422) pythonGH-104371: check return value of calling `mv.release` (python#104417) pythongh-104415: Fix refleak tests for `typing.ByteString` deprecation (python#104416) pythonGH-86275: Implementation of hypothesis stubs for property-based tests, with zoneinfo tests (python#22863) pythonGH-103082: Filter LINE events in VM, to simplify tool implementation. (pythonGH-104387) pythongh-93649: Split gc- and allocation tests from _testcapimodule.c (pythonGH-104403) pythongh-104389: Add 'unused' keyword to Argument Clinic C converters (python#104390) pythongh-101819: Prepare _io._IOBase for module state (python#104386) pythongh-104413: Fix refleak when super attribute throws AttributeError (python#104414) Fix refleak in `super_descr_get` (python#104408) pythongh-87526: Remove dead initialization from _zoneinfo parse_abbr() (python#24700) pythongh-91896: Improve visibility of `ByteString` deprecation warnings (python#104294) pythongh-104371: Fix calls to `__release_buffer__` while an exception is active (python#104378) pythongh-104377: fix cell in comprehension that is free in outer scope (python#104394) pythongh-104392: Remove _paramspec_tvars from typing (python#104393) pythongh-104396: uuid.py to skip platform check for emscripten and wasi (pythongh-104397) pythongh-99108: Refresh HACL* from upstream (python#104401) pythongh-104301: Allow leading whitespace in disambiguated pdb statements (python#104342)
AlexWaygood deleted the more-bytestring-deprecations branch May 12, 2023 18:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

JelleZijlstra JelleZijlstra approved these changes
hauntsaninja Awaiting requested review from hauntsaninja
rhettinger Awaiting requested review from rhettinger rhettinger is a code owner

Assignees

No one assigned

Labels

3.12 only security fixes docs Documentation in the Doc dir skip news topic-typing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Footer

© 2026 GitHub, Inc.