← 返回首页
gh-101819: Fix inverted debug preprocessor check in winconsoleio.c by erlend-aasland · Pull Request #104388 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

gh-101819: Fix inverted debug preprocessor check in winconsoleio.c#104388

Merged
erlend-aasland merged 1 commit into
python:mainfrom
erlend-aasland:isolate-io/address-reviews
May 11, 2023
Merged

gh-101819: Fix inverted debug preprocessor check in winconsoleio.c#104388
erlend-aasland merged 1 commit into
python:mainfrom
erlend-aasland:isolate-io/address-reviews

Conversation

erlend-aasland commented May 11, 2023 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

erlend-aasland requested a review from vstinner May 11, 2023 12:30
bedevere-bot mentioned this pull request May 11, 2023
Closed
vstinner approved these changes May 11, 2023
View reviewed changes

vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

LGTM

erlend-aasland enabled auto-merge (squash) May 11, 2023 12:58
erlend-aasland merged commit ddc0e70 into python:main May 11, 2023
carljm added a commit to carljm/cpython that referenced this pull request May 11, 2023
Merge branch 'main' into supermon …
fb47955
* main: pythongh-104057: Fix direct invocation of test_support (pythonGH-104069) pythongh-87729: improve hit rate of LOAD_SUPER_ATTR specialization (python#104270) pythongh-101819: Fix inverted debug preprocessor check in winconsoleio.c (python#104388)
erlend-aasland deleted the isolate-io/address-reviews branch May 21, 2023 21:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

vstinner vstinner approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Footer

© 2026 GitHub, Inc.