← 返回首页
gh-104371: Fix calls to __release_buffer__ while an exception is active by JelleZijlstra · Pull Request #104378 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
Resetting focus

gh-104371: Fix calls to __release_buffer__ while an exception is active#104378

Merged
kumaraditya303 merged 3 commits into
python:mainfrom
JelleZijlstra:rbcheck
May 12, 2023
Merged

gh-104371: Fix calls to __release_buffer__ while an exception is active#104378
kumaraditya303 merged 3 commits into
python:mainfrom
JelleZijlstra:rbcheck

Conversation

JelleZijlstra commented May 11, 2023
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

Comment thread Objects/typeobject.c Outdated Show resolved Hide resolved
Comment thread Objects/typeobject.c Outdated Show resolved Hide resolved

Copy link
Copy Markdown

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

Copy link
Copy Markdown
Member Author

Thanks for the review @kumaraditya303!

I have made the requested changes; please review again.

Copy link
Copy Markdown

Thanks for making the requested changes!

@kumaraditya303: please review the changes made to this pull request.

kumaraditya303 enabled auto-merge (squash) May 12, 2023 05:04
kumaraditya303 merged commit a0a98dd into python:main May 12, 2023
JelleZijlstra deleted the rbcheck branch May 12, 2023 05:26

markshannon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

This fix doesn't appear to be correct.

Comment thread Objects/typeobject.c Show resolved Hide resolved
Comment thread Objects/typeobject.c Show resolved Hide resolved
carljm added a commit to carljm/cpython that referenced this pull request May 12, 2023
* main: pythongh-91896: Fixup some docs issues following ByteString deprecation (python#104422) pythonGH-104371: check return value of calling `mv.release` (python#104417) pythongh-104415: Fix refleak tests for `typing.ByteString` deprecation (python#104416) pythonGH-86275: Implementation of hypothesis stubs for property-based tests, with zoneinfo tests (python#22863) pythonGH-103082: Filter LINE events in VM, to simplify tool implementation. (pythonGH-104387) pythongh-93649: Split gc- and allocation tests from _testcapimodule.c (pythonGH-104403) pythongh-104389: Add 'unused' keyword to Argument Clinic C converters (python#104390) pythongh-101819: Prepare _io._IOBase for module state (python#104386) pythongh-104413: Fix refleak when super attribute throws AttributeError (python#104414) Fix refleak in `super_descr_get` (python#104408) pythongh-87526: Remove dead initialization from _zoneinfo parse_abbr() (python#24700) pythongh-91896: Improve visibility of `ByteString` deprecation warnings (python#104294) pythongh-104371: Fix calls to `__release_buffer__` while an exception is active (python#104378) pythongh-104377: fix cell in comprehension that is free in outer scope (python#104394) pythongh-104392: Remove _paramspec_tvars from typing (python#104393) pythongh-104396: uuid.py to skip platform check for emscripten and wasi (pythongh-104397) pythongh-99108: Refresh HACL* from upstream (python#104401) pythongh-104301: Allow leading whitespace in disambiguated pdb statements (python#104342)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Footer

© 2026 GitHub, Inc.