← 返回首页
GH-102613: Fix recursion error from `pathlib.Path.glob()` by barneygale · Pull Request #104373 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

GH-102613: Fix recursion error from pathlib.Path.glob()#104373

Merged
barneygale merged 1 commit into
python:mainfrom
barneygale:gh-102613-glob-recursionerror
May 15, 2023
Merged

GH-102613: Fix recursion error from pathlib.Path.glob()#104373
barneygale merged 1 commit into
python:mainfrom
barneygale:gh-102613-glob-recursionerror

Conversation

barneygale commented May 11, 2023 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

Use Path.walk() to implement the recursive wildcard **. This method uses an iterative (rather than recursive) walk - see GH-100282.

pythonGH-102613: Fix recursion error from pathlib.Path.glob() …
71dc988
Use `Path.walk()` to implement the recursive wildcard `**`. This method uses an iterative (rather than recursive) walk - see pythonGH-100282.
bedevere-bot mentioned this pull request May 11, 2023
Closed

barneygale commented May 11, 2023

Copy link
Copy Markdown
Contributor Author

This won't backport to 3.11, as Path.walk() is new in 3.12.

barneygale commented May 11, 2023

Copy link
Copy Markdown
Contributor Author

@Ovsyanka83 would you like to review, if you have a mo? Uses your shiny walk() method! :)

zmievsa commented May 11, 2023

Copy link
Copy Markdown
Contributor

Will take a look on saturday! :)

zmievsa suggested changes May 13, 2023
View reviewed changes

zmievsa left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

Thanks for using our work here! Every time "walk" gets used or mentioned, it makes me feel really nice and like my work has made a difference :D

I like the ideas and have a few suggestions here and there -- your logic feels quite right and my changes are doubtful and mostly stylistic :)

Comment thread Misc/NEWS.d/next/Library/2023-05-11-01-07-42.gh-issue-102613.uMsokt.rst Show resolved Hide resolved
Comment thread Lib/pathlib.py Show resolved Hide resolved
Comment thread Lib/pathlib.py Show resolved Hide resolved
Comment thread Lib/pathlib.py Show resolved Hide resolved
zmievsa approved these changes May 14, 2023
View reviewed changes

zmievsa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

After your replies the logic itself makes much more sense so I'm ready to approve this.

barneygale commented May 14, 2023

Copy link
Copy Markdown
Contributor Author

Thank you!

barneygale commented May 14, 2023

Copy link
Copy Markdown
Contributor Author

Hey @carljm, would you be up for reviewing this? You reviewed #100282 which made Path.walk() iterative; it's that work I'm exploiting here. No worries if not, thank you!

carljm approved these changes May 15, 2023
View reviewed changes

carljm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

This looks good to me, apart from the one inline comment, which could be addressed as a follow-up also.

Comment thread Lib/pathlib.py Show resolved Hide resolved
barneygale merged commit cb88ae6 into python:main May 15, 2023
carljm added a commit to carljm/cpython that referenced this pull request May 16, 2023
Merge branch 'main' into supermon …
a6dd626
* main: pythonGH-104510: Fix refleaks in `_io` base types (python#104516) pythongh-104539: Fix indentation error in logging.config.rst (python#104545) pythongh-104050: Don't star-import 'types' in Argument Clinic (python#104543) pythongh-104050: Add basic typing to CConverter in clinic.py (python#104538) pythongh-64595: Fix write file logic in Argument Clinic (python#104507) pythongh-104523: Inline minimal PGO rules (python#104524) pythongh-103861: Fix Zip64 extensions not being properly applied in some cases (python#103863) pythongh-69152: add method get_proxy_response_headers to HTTPConnection class (python#104248) pythongh-103763: Implement PEP 695 (python#103764) pythongh-104461: Run tkinter test_configure_screen on X11 only (pythonGH-104462) pythongh-104469: Convert _testcapi/watchers.c to use Argument Clinic (python#104503) pythongh-104482: Fix error handling bugs in ast.c (python#104483) pythongh-104341: Adjust tstate_must_exit() to Respect Interpreter Finalization (pythongh-104437) pythonGH-102613: Fix recursion error from `pathlib.Path.glob()` (pythonGH-104373)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

AlexWaygood AlexWaygood left review comments
carljm carljm approved these changes
+1 more reviewer
zmievsa zmievsa approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

topic-pathlib

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Footer

© 2026 GitHub, Inc.