← 返回首页
gh-104301: Allow leading whitespace in disambiguated pdb statements by SnoopJ · Pull Request #104342 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

gh-104301: Allow leading whitespace in disambiguated pdb statements#104342

Merged
iritkatriel merged 8 commits into
python:mainfrom
SnoopJ:gh-104301_pdb-allow-leading-statement-whitespace
May 11, 2023
Merged

gh-104301: Allow leading whitespace in disambiguated pdb statements#104342
iritkatriel merged 8 commits into
python:mainfrom
SnoopJ:gh-104301_pdb-allow-leading-statement-whitespace

Conversation

SnoopJ commented May 9, 2023 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor

This changeset fixes #104301 by allowing leading whitespace in statements prefixed by ! in pdb, as an alternate to #104302, suggested here.

This PR also adds a corresponding example of the pdb documentation.

📚 Documentation preview 📚: https://cpython-previews--104342.org.readthedocs.build/

bedevere-bot mentioned this pull request May 9, 2023
Closed
gaogaotiantian reviewed May 10, 2023
View reviewed changes
Comment thread Lib/pdb.py Outdated Show resolved Hide resolved

iritkatriel commented May 11, 2023

Copy link
Copy Markdown
Member

Do we have tests for this feature?

gaogaotiantian commented May 11, 2023

Copy link
Copy Markdown
Member

Ah right, totally forgot about that. @SnoopJ could you add some test case to use ! with spaces? The doctests in test_pdb.py should not be too hard to follow, let me know if you have any questions.

SnoopJ commented May 11, 2023

Copy link
Copy Markdown
Contributor Author

No problem, added in ebf179d. I couldn't find any pre-existing tests of the feature, so let me know if the test I added should also explicitly test the spelling without any leading whitespace

iritkatriel reviewed May 11, 2023
View reviewed changes
Comment thread Lib/test/test_pdb.py Outdated Show resolved Hide resolved
iritkatriel reviewed May 11, 2023
View reviewed changes
Comment thread Lib/test/test_pdb.py Outdated Show resolved Hide resolved
SnoopJ and others added 2 commits May 11, 2023 11:22
Use more explicit print()
ac6e0e3
Use better name for test …
778a4ef
Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
SnoopJ force-pushed the gh-104301_pdb-allow-leading-statement-whitespace branch from 84ad82a to 778a4ef Compare May 11, 2023 15:25

SnoopJ commented May 11, 2023

Copy link
Copy Markdown
Contributor Author

Sorry about the force-push, I wanted to be sure that the Co-authored-by attribution was present since I didn't use the suggestion UI to make that change.

iritkatriel added type-feature A feature request or enhancement stdlib Standard Library Python modules in the Lib/ directory labels May 11, 2023

iritkatriel commented May 11, 2023

Copy link
Copy Markdown
Member

Sorry about the force-push, I wanted to be sure that the Co-authored-by attribution was present since I didn't use the suggestion UI to make that change.

There's no need for it (minor code review suggestions do not typically need to imply coauthorship).

iritkatriel commented May 11, 2023

Copy link
Copy Markdown
Member

there's a test failure

SnoopJ mentioned this pull request May 11, 2023
Closed
iritkatriel merged commit 0449ffe into python:main May 11, 2023
SnoopJ deleted the gh-104301_pdb-allow-leading-statement-whitespace branch May 11, 2023 17:18
carljm added a commit to carljm/cpython that referenced this pull request May 12, 2023
Merge branch 'main' into supermon …
8efd7c6
* main: pythongh-91896: Fixup some docs issues following ByteString deprecation (python#104422) pythonGH-104371: check return value of calling `mv.release` (python#104417) pythongh-104415: Fix refleak tests for `typing.ByteString` deprecation (python#104416) pythonGH-86275: Implementation of hypothesis stubs for property-based tests, with zoneinfo tests (python#22863) pythonGH-103082: Filter LINE events in VM, to simplify tool implementation. (pythonGH-104387) pythongh-93649: Split gc- and allocation tests from _testcapimodule.c (pythonGH-104403) pythongh-104389: Add 'unused' keyword to Argument Clinic C converters (python#104390) pythongh-101819: Prepare _io._IOBase for module state (python#104386) pythongh-104413: Fix refleak when super attribute throws AttributeError (python#104414) Fix refleak in `super_descr_get` (python#104408) pythongh-87526: Remove dead initialization from _zoneinfo parse_abbr() (python#24700) pythongh-91896: Improve visibility of `ByteString` deprecation warnings (python#104294) pythongh-104371: Fix calls to `__release_buffer__` while an exception is active (python#104378) pythongh-104377: fix cell in comprehension that is free in outer scope (python#104394) pythongh-104392: Remove _paramspec_tvars from typing (python#104393) pythongh-104396: uuid.py to skip platform check for emscripten and wasi (pythongh-104397) pythongh-99108: Refresh HACL* from upstream (python#104401) pythongh-104301: Allow leading whitespace in disambiguated pdb statements (python#104342)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

iritkatriel iritkatriel approved these changes
gaogaotiantian gaogaotiantian approved these changes

Assignees

No one assigned

Labels

stdlib Standard Library Python modules in the Lib/ directory type-feature A feature request or enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Misleading documentation of ! prefix in pdb

4 participants

Footer

© 2026 GitHub, Inc.