← 返回首页
gh-101819: Refactor _io in preparation for module isolation by erlend-aasland · Pull Request #104334 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

gh-101819: Refactor _io in preparation for module isolation#104334

Merged
erlend-aasland merged 12 commits into
python:mainfrom
erlend-aasland:isolate-io/refactorings
May 9, 2023
Merged

gh-101819: Refactor _io in preparation for module isolation#104334
erlend-aasland merged 12 commits into
python:mainfrom
erlend-aasland:isolate-io/refactorings

Conversation

erlend-aasland commented May 9, 2023 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

Refactor: replace query with parameter …
14f923e
Pass module state to bufferediobase_unsupported()
Refactor: replace query with parameter …
482f134
Pass module state to iobase_unsupported()
Refactor: hide delegate …
8adc0cd
Add method wrapper for _PyIOBase_check_seekable.
Refactor: hide delegate …
703440a
Add method wraper for _PyIOBase_check_readable
Refactor: hide delegate …
ea9c098
Add method wraper for _PyIOBase_check_writable
Add io state struct forward declaration.
e940ed3
Refactor: replace query with parameter …
c68d657
Pass module state to _PyIOBase_check_seekable()
Refactor: replace query with parameter …
0084715
Pass module state to _PyIOBase_check_readable()
Refactor: replace query with parameter …
20777e7
Pass module state to _PyIOBase_check_writable()
bedevere-bot mentioned this pull request May 9, 2023
Closed
vstinner approved these changes May 9, 2023
View reviewed changes

vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

LGTM, I just have a coding style suggestion for the header file (_iomodule.h).

Comment thread Modules/_io/_iomodule.h Outdated Show resolved Hide resolved
erlend-aasland enabled auto-merge (squash) May 9, 2023 22:32
vstinner reviewed May 9, 2023
View reviewed changes
Comment thread Modules/_io/_iomodule.h Outdated Show resolved Hide resolved
Address review: remove second typedef …
7aa8da7
It may provoke compiler warnings
vstinner approved these changes May 9, 2023
View reviewed changes

vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

LGTM. The _iomodule.h typedef LGTM.

erlend-aasland merged commit 235b827 into python:main May 9, 2023
erlend-aasland deleted the isolate-io/refactorings branch May 10, 2023 04:41
carljm added a commit to carljm/cpython that referenced this pull request May 10, 2023
Merge branch 'main' into fixloadsuperspec …
5976df9
* main: pythonGH-102181: Improve specialization stats for SEND (pythonGH-102182) pythongh-103000: Optimise `dataclasses.asdict` for the common case (python#104364) pythongh-103538: Remove unused TK_AQUA code (pythonGH-103539) pythonGH-87695: Fix OSError from `pathlib.Path.glob()` (pythonGH-104292) pythongh-104263: Rely on Py_NAN and introduce Py_INFINITY (pythonGH-104202) pythongh-104010: Separate and improve docs for `typing.get_origin` and `typing.get_args` (python#104013) pythongh-101819: Adapt _io._BufferedIOBase_Type methods to Argument Clinic (python#104355) pythongh-103960: Dark mode: invert image brightness (python#103983) pythongh-104252: Immortalize Py_EMPTY_KEYS (pythongh-104253) pythongh-101819: Clean up _io windows console io after pythongh-104197 (python#104354) pythongh-101819: Harden _io init (python#104352) pythongh-103247: clear the module cache in a test in test_importlib/extensions/test_loader.py (pythonGH-104226) pythongh-103848: Adds checks to ensure that bracketed hosts found by urlsplit are of IPv6 or IPvFuture format (python#103849) pythongh-74895: adjust tests to work on Solaris (python#104326) pythongh-101819: Refactor _io in preparation for module isolation (python#104334) pythongh-90953: Don't use deprecated AST nodes in clinic.py (python#104322) pythongh-102327: Extend docs for "url" and "headers" parameters to HTTPConnection.request() pythongh-104328: Fix typo in ``typing.Generic`` multiple inheritance error message (python#104335)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

vstinner vstinner approved these changes
kumaraditya303 Awaiting requested review from kumaraditya303

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Footer

© 2026 GitHub, Inc.