← 返回首页
gh-90953: Don't use deprecated AST nodes in clinic.py by AlexWaygood · Pull Request #104322 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

gh-90953: Don't use deprecated AST nodes in clinic.py#104322

Merged
AlexWaygood merged 1 commit into
python:mainfrom
AlexWaygood:clinic-deprecation
May 9, 2023
Merged

gh-90953: Don't use deprecated AST nodes in clinic.py#104322
AlexWaygood merged 1 commit into
python:mainfrom
AlexWaygood:clinic-deprecation

Conversation

AlexWaygood commented May 9, 2023 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

Following 376137f, usage of ast.Num and ast.Str causes DeprecationWarnings to be emitted. This PR updates clinic.py to use the newer AST nodes, avoiding deprecation warnings when running test_clinic.py.

It looks like this script currently takes pains so that it can maintain compatibility with older Python versions. This change means that it won't be possible to run it on Python 3.7 anymore, but Python 3.7 is nearly end-of-life now anyway.

AlexWaygood requested a review from erlend-aasland May 9, 2023 12:40
bedevere-bot mentioned this pull request May 9, 2023
Closed

sunmy2019 commented May 9, 2023

Copy link
Copy Markdown
Member

LGTM

erlend-aasland commented May 9, 2023

Copy link
Copy Markdown
Contributor

I think it is fine to require Python 3.8 for clinic.py. Argument Clinic is for CPython development, and its primary purpose is to generate code for this repo. Third party projects may use it, but must do so completely at their own risk.

AlexWaygood merged commit fe694a6 into python:main May 9, 2023
AlexWaygood deleted the clinic-deprecation branch May 9, 2023 21:16

AlexWaygood commented May 9, 2023

Copy link
Copy Markdown
Member Author

Thanks both!

carljm added a commit to carljm/cpython that referenced this pull request May 10, 2023
Merge branch 'main' into fixloadsuperspec …
5976df9
* main: pythonGH-102181: Improve specialization stats for SEND (pythonGH-102182) pythongh-103000: Optimise `dataclasses.asdict` for the common case (python#104364) pythongh-103538: Remove unused TK_AQUA code (pythonGH-103539) pythonGH-87695: Fix OSError from `pathlib.Path.glob()` (pythonGH-104292) pythongh-104263: Rely on Py_NAN and introduce Py_INFINITY (pythonGH-104202) pythongh-104010: Separate and improve docs for `typing.get_origin` and `typing.get_args` (python#104013) pythongh-101819: Adapt _io._BufferedIOBase_Type methods to Argument Clinic (python#104355) pythongh-103960: Dark mode: invert image brightness (python#103983) pythongh-104252: Immortalize Py_EMPTY_KEYS (pythongh-104253) pythongh-101819: Clean up _io windows console io after pythongh-104197 (python#104354) pythongh-101819: Harden _io init (python#104352) pythongh-103247: clear the module cache in a test in test_importlib/extensions/test_loader.py (pythonGH-104226) pythongh-103848: Adds checks to ensure that bracketed hosts found by urlsplit are of IPv6 or IPvFuture format (python#103849) pythongh-74895: adjust tests to work on Solaris (python#104326) pythongh-101819: Refactor _io in preparation for module isolation (python#104334) pythongh-90953: Don't use deprecated AST nodes in clinic.py (python#104322) pythongh-102327: Extend docs for "url" and "headers" parameters to HTTPConnection.request() pythongh-104328: Fix typo in ``typing.Generic`` multiple inheritance error message (python#104335)
AlexWaygood mentioned this pull request May 12, 2023
Merged

miss-islington-app Bot commented Oct 31, 2025

Copy link
Copy Markdown

Thanks @AlexWaygood for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington-app Bot commented Oct 31, 2025

Copy link
Copy Markdown

Thanks @AlexWaygood for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

miss-islington-app Bot commented Oct 31, 2025

Copy link
Copy Markdown

Thanks @AlexWaygood for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

miss-islington-app Bot commented Oct 31, 2025

Copy link
Copy Markdown

Thanks @AlexWaygood for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 31, 2025
pythongh-90953: Don't use deprecated AST nodes in clinic.py (pythonGH… …
eaf62ab
…-104322) (cherry picked from commit fe694a6) Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 31, 2025
pythongh-90953: Don't use deprecated AST nodes in clinic.py (pythonGH… …
e8cd18d
…-104322) (cherry picked from commit fe694a6) Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>

bedevere-app Bot commented Oct 31, 2025

Copy link
Copy Markdown

GH-140854 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 31, 2025
pythongh-90953: Don't use deprecated AST nodes in clinic.py (pythonGH… …
1e8f2e7
…-104322) (cherry picked from commit fe694a6) Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>

miss-islington-app Bot commented Oct 31, 2025

Copy link
Copy Markdown

Sorry, @AlexWaygood, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker fe694a6db620062f467469bd2bb987315d72fd62 3.12

bedevere-app Bot commented Oct 31, 2025

Copy link
Copy Markdown

GH-140855 is a backport of this pull request to the 3.10 branch.

bedevere-app Bot removed the needs backport to 3.10 only security fixes label Oct 31, 2025

bedevere-app Bot commented Oct 31, 2025

Copy link
Copy Markdown

GH-140856 is a backport of this pull request to the 3.11 branch.

bedevere-app Bot removed the needs backport to 3.11 only security fixes label Oct 31, 2025
ambv removed the needs backport to 3.12 only security fixes label Oct 31, 2025
ambv pushed a commit that referenced this pull request Oct 31, 2025
[3.10] gh-90953: Don't use deprecated AST nodes in clinic.py (GH-104322… …
9524203
…) (GH-140855) (cherry picked from commit fe694a6) Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
ambv pushed a commit that referenced this pull request Oct 31, 2025
[3.9] gh-90953: Don't use deprecated AST nodes in clinic.py (GH-104322)… …
fde6ac1
… (GH-140854) (cherry picked from commit fe694a6) Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
ambv pushed a commit that referenced this pull request Oct 31, 2025
[3.11] gh-90953: Don't use deprecated AST nodes in clinic.py (GH-104322… …
20fe182
…) (GH-140856) (cherry picked from commit fe694a6) Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
AlexWaygood removed their assignment Oct 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

erlend-aasland erlend-aasland approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Footer

© 2026 GitHub, Inc.