← 返回首页
gh-101819: Port _io.PyBytesIOBuffer_Type to heap type by erlend-aasland · Pull Request #104264 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

gh-101819: Port _io.PyBytesIOBuffer_Type to heap type#104264

Merged
erlend-aasland merged 2 commits into
python:mainfrom
erlend-aasland:isolate-io/bytesiobuf
May 7, 2023
Merged

gh-101819: Port _io.PyBytesIOBuffer_Type to heap type#104264
erlend-aasland merged 2 commits into
python:mainfrom
erlend-aasland:isolate-io/bytesiobuf

Conversation

erlend-aasland commented May 7, 2023 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

bedevere-bot mentioned this pull request May 7, 2023
Closed
erlend-aasland added the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label May 7, 2023

bedevere-bot commented May 7, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @erlend-aasland for commit 7e628db 🤖

If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again.

bedevere-bot removed the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label May 7, 2023
erlend-aasland mentioned this pull request May 7, 2023
Merged
erlend-aasland commented May 7, 2023
View reviewed changes
Comment thread Modules/_io/_iomodule.c Outdated

// PyRawIOBase_Type(PyIOBase_Type) subclasses
state->PyBytesIOBuffer_Type = (PyTypeObject *)Py_NewRef(&_PyBytesIOBuffer_Type);
ADD_TYPE(m, state->PyBytesIOBuffer_Type, &bytesiobuf_spec, NULL); // XXX: should be subclass of PyRawIOBase_Type?

erlend-aasland May 7, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

FYI, I'll remove the XXX comment and move this line up to 753 when the refleak CI comes out green.

erlend-aasland commented May 7, 2023

Copy link
Copy Markdown
Contributor Author

CI including refleak bots are all green. I'll resolve my remark from #104264 (comment) and enable automerge.

erlend-aasland enabled auto-merge (squash) May 7, 2023 13:32
erlend-aasland merged commit 7a7eaff into python:main May 7, 2023
erlend-aasland deleted the isolate-io/bytesiobuf branch May 7, 2023 14:20
jbower-fb pushed a commit to jbower-fb/cpython that referenced this pull request May 8, 2023
pythongh-101819: Port _io.PyBytesIOBuffer_Type to heap type (python#1… …
b61f7d2
…04264)
vstinner reviewed May 9, 2023
View reviewed changes

vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

Review after the merge: LGTM.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

vstinner vstinner left review comments
kumaraditya303 kumaraditya303 approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Footer

© 2026 GitHub, Inc.