← 返回首页
gh-97696: Use PyObject_CallMethodNoArgs and inline is_loop_running check by itamaro · Pull Request #104255 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

gh-97696: Use PyObject_CallMethodNoArgs and inline is_loop_running check#104255

Merged
kumaraditya303 merged 1 commit into
python:mainfrom
itamaro:inline-is-loop-running
May 7, 2023
Merged

gh-97696: Use PyObject_CallMethodNoArgs and inline is_loop_running check#104255
kumaraditya303 merged 1 commit into
python:mainfrom
itamaro:inline-is-loop-running

Conversation

itamaro commented May 7, 2023 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

bedevere-bot mentioned this pull request May 7, 2023
Closed
gvanrossum approved these changes May 7, 2023
View reviewed changes

gvanrossum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

LGTM, but this was @kumaraditya303's idea so he can review and merge it.

itamaro commented May 7, 2023

Copy link
Copy Markdown
Contributor Author

LGTM, but this was @kumaraditya303's idea so he can review and merge it.

thanks! can you trigger refleak buildbots in the meantime so @kumaraditya303 can merge with confidence when he gets to it? :)

JelleZijlstra added the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label May 7, 2023

bedevere-bot commented May 7, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @JelleZijlstra for commit 20048db 🤖

If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again.

bedevere-bot removed the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label May 7, 2023
kumaraditya303 merged commit c53547c into python:main May 7, 2023
itamaro deleted the inline-is-loop-running branch May 7, 2023 04:50
jbower-fb pushed a commit to jbower-fb/cpython that referenced this pull request May 8, 2023
pythongh-97696: Use PyObject_CallMethodNoArgs and inline is_loop_ru… …
44b081d
…nning check in `_asyncio` (python#104255)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

gvanrossum gvanrossum approved these changes
kumaraditya303 kumaraditya303 approved these changes
1st1 Awaiting requested review from 1st1 1st1 is a code owner
asvetlov Awaiting requested review from asvetlov asvetlov is a code owner
willingc Awaiting requested review from willingc willingc is a code owner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Footer

© 2026 GitHub, Inc.