|
I was able to repro the reported failure on main, and confirmed this PR fixes it. I'm not sure adding the tearDown is helpful though. in any case, I also confirmed that just adding the context manager to test_try_registration without the tearDown fixes the issue. |
Sorry, something went wrong.
|
I'm not sure adding the tearDown is helpful though. Adding this is proposed by @FFY00. And I am neutral about it. |
Sorry, something went wrong.
|
I'm not sure adding the tearDown is helpful though. I think you are correct, adding both is unnecessary. tearDown method and util.uncache provides duplicate function. And util.uncache(name) provides more flexibility than the tearDown method. tearDown here is a safety net. But do we want to expose the problem early or make the system more robust? I prefer the former since it's a test case. Thus, I will remove this safe net for now. |
Sorry, something went wrong.
There was a problem hiding this comment.
LGTM!
Sorry, something went wrong.
|
Thanks @sunmy2019 for the PR, and @brettcannon for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11. |
Sorry, something went wrong.
|
GH-104345 is a backport of this pull request to the 3.11 branch. |
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.