← 返回首页
GH-104102: Optimize `pathlib.Path.glob()` handling of `../` pattern segments by barneygale · Pull Request #104103 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

GH-104102: Optimize pathlib.Path.glob() handling of ../ pattern segments#104103

Merged
barneygale merged 4 commits into
python:mainfrom
barneygale:gh-104102-optimize-glob-parent
May 2, 2023
Merged

GH-104102: Optimize pathlib.Path.glob() handling of ../ pattern segments#104103
barneygale merged 4 commits into
python:mainfrom
barneygale:gh-104102-optimize-glob-parent

Conversation

barneygale commented May 2, 2023 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

These segments do not require a stat() call, as the selector's _select_from() method is called after we've established that the parent is a directory.

This PR adds a new _ParentSelector class, which is used to evaluate ../ segments rather than _PreciseSelector.

Optimize pathlib.Path.glob() handling of ../ pattern segments …
f268157
These segments do not require a `stat()` call, as the selector's `_select_from()` method is called after we've established that the parent is a directory.
barneygale added performance Performance or resource usage topic-pathlib labels May 2, 2023
barneygale changed the title Optimize pathlib.Path.glob() handling of ../ pattern segments GH-104102: Optimize pathlib.Path.glob() handling of ../ pattern segments May 2, 2023
bedevere-bot mentioned this pull request May 2, 2023
Closed
barneygale mentioned this pull request May 2, 2023
Merged
AlexWaygood reviewed May 2, 2023
View reviewed changes
Comment thread Lib/pathlib.py Show resolved Hide resolved

AlexWaygood commented May 2, 2023

Copy link
Copy Markdown
Member

I think we could add some more tests here. There don't seem to be any tests for patterns with two successive .. segments, e.g. Path(".").glob("../../*"), or any test cases for "extreme" patterns, such as Path(".").glob(("../" * 50) + "*").

AlexWaygood approved these changes May 2, 2023
View reviewed changes

AlexWaygood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

Looks fab to me other than my point about test coverage! Great work.

AlexWaygood added type-feature A feature request or enhancement 3.12 only security fixes labels May 2, 2023
barneygale enabled auto-merge (squash) May 2, 2023 22:55

barneygale commented May 2, 2023

Copy link
Copy Markdown
Contributor Author

Thank you Alex!

barneygale merged commit 65a49c6 into python:main May 2, 2023
carljm added a commit to carljm/cpython that referenced this pull request May 2, 2023
Merge branch 'main' into cached_property_docs …
b9c39e3
* main: (760 commits) pythonGH-104102: Optimize `pathlib.Path.glob()` handling of `../` pattern segments (pythonGH-104103) pythonGH-104104: Optimize `pathlib.Path.glob()` by avoiding repeated calls to `os.path.normcase()` (pythonGH-104105) pythongh-103822: [Calendar] change return value to enum for day and month APIs (pythonGH-103827) pythongh-65022: Fix description of tuple return value in copyreg (python#103892) pythonGH-103525: Improve exception message from `pathlib.PurePath()` (pythonGH-103526) pythongh-84436: Add integration C API tests for immortal objects (pythongh-103962) pythongh-103743: Add PyUnstable_Object_GC_NewWithExtraData (pythonGH-103744) pythongh-102997: Update Windows installer to SQLite 3.41.2. (python#102999) pythonGH-103484: Fix redirected permanently URLs (python#104001) Improve assert_type phrasing (python#104081) pythongh-102997: Update macOS installer to SQLite 3.41.2. (pythonGH-102998) pythonGH-103472: close response in HTTPConnection._tunnel (python#103473) pythongh-88496: IDLE - fix another test on macOS (python#104075) pythongh-94673: Hide Objects in PyTypeObject Behind Accessors (pythongh-104074) pythongh-94673: Properly Initialize and Finalize Static Builtin Types for Each Interpreter (pythongh-104072) pythongh-104016: Skip test for deeply neste f-strings on wasi (python#104071) pythongh-104057: Fix direct invocation of test_super (python#104064) pythongh-87092: Expose assembler to unit tests (python#103988) pythongh-97696: asyncio eager tasks factory (python#102853) pythongh-84436: Immortalize in _PyStructSequence_InitBuiltinWithFlags() (pythongh-104054) ...
barneygale mentioned this pull request May 3, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

AlexWaygood AlexWaygood approved these changes

Assignees

No one assigned

Labels

3.12 only security fixes performance Performance or resource usage topic-pathlib type-feature A feature request or enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Footer

© 2026 GitHub, Inc.