← 返回首页
gh-88496: IDLE - fix another test on macOS by terryjreedy · Pull Request #104075 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

gh-88496: IDLE - fix another test on macOS#104075

Merged
terryjreedy merged 1 commit into
python:mainfrom
terryjreedy:update2
May 2, 2023
Merged

gh-88496: IDLE - fix another test on macOS#104075
terryjreedy merged 1 commit into
python:mainfrom
terryjreedy:update2

Conversation

terryjreedy commented May 2, 2023 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

Needed for Catalina: test_sidebar add 'idletasks' and skip assert.

pythongh-88496: IDLE - fix another test on macOS …
fd0948a
Needed for Catalina: test_sidebar add 'idletasks' and skip assert.
terryjreedy self-assigned this May 2, 2023
bedevere-bot mentioned this pull request May 2, 2023
Closed
bedevere-bot added the tests Tests in the Lib/test dir label May 2, 2023
terryjreedy enabled auto-merge (squash) May 2, 2023 02:28
terryjreedy merged commit 690df4c into python:main May 2, 2023

miss-islington commented May 2, 2023

Copy link
Copy Markdown
Contributor

Thanks @terryjreedy for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

terryjreedy added needs backport to 3.11 only security fixes and removed needs backport to 3.11 only security fixes labels May 2, 2023

miss-islington commented May 2, 2023

Copy link
Copy Markdown
Contributor

Thanks @terryjreedy for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

bedevere-bot commented May 2, 2023

Copy link
Copy Markdown

GH-104076 is a backport of this pull request to the 3.11 branch.

bedevere-bot removed the needs backport to 3.11 only security fixes label May 2, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 2, 2023
pythongh-88496: IDLE - fix another test on macOS (pythonGH-104075) …
f85e707
Needed for Catalina: test_sidebar add 'idletasks' and skip assert. (cherry picked from commit 690df4c) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
terryjreedy deleted the update2 branch May 2, 2023 02:54
python deleted a comment from miss-islington May 2, 2023
terryjreedy added a commit that referenced this pull request May 2, 2023
[3.11] gh-88496: IDLE - fix another test on macOS (GH-104075) (#104076) …
9f191a1
gh-88496: IDLE - fix another test on macOS (GH-104075) Needed for Catalina: test_sidebar add 'idletasks' and skip assert. (cherry picked from commit 690df4c) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
chrstphrchvz mentioned this pull request May 2, 2023
Merged
chrstphrchvz reviewed May 2, 2023
View reviewed changes
Comment thread Lib/idlelib/idle_test/test_sidebar.py
sidebar.canvas.event_generate('<MouseWheel>', x=0, y=0, delta=delta)
yield
self.assertIsNone(text.dlineinfo(text.index(f'{last_lineno}.0')))
if sys.platform != 'darwin': # .update_idletasks() does not work.

chrstphrchvz May 2, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

Ordinarily I would ask if this test should continue to run on XQuartz if the problem is only on Aqua:

Suggested change
if sys.platform != 'darwin': # .update_idletasks() does not work.
if text._windowingsystem != 'aqua': # .update_idletasks() does not work.

But this test was already failing on Aqua and XQuartz due to incorrectly negative delta. So this failure may have nothing to do with .update_idletasks(), and the test should not be skipped on Aqua or XQuartz. See #103820, #103821

carljm added a commit to carljm/cpython that referenced this pull request May 2, 2023
Merge branch 'main' into inlinecomp2 …
0727d6f
* main: pythongh-103822: [Calendar] change return value to enum for day and month APIs (pythonGH-103827) pythongh-65022: Fix description of tuple return value in copyreg (python#103892) pythonGH-103525: Improve exception message from `pathlib.PurePath()` (pythonGH-103526) pythongh-84436: Add integration C API tests for immortal objects (pythongh-103962) pythongh-103743: Add PyUnstable_Object_GC_NewWithExtraData (pythonGH-103744) pythongh-102997: Update Windows installer to SQLite 3.41.2. (python#102999) pythonGH-103484: Fix redirected permanently URLs (python#104001) Improve assert_type phrasing (python#104081) pythongh-102997: Update macOS installer to SQLite 3.41.2. (pythonGH-102998) pythonGH-103472: close response in HTTPConnection._tunnel (python#103473) pythongh-88496: IDLE - fix another test on macOS (python#104075) pythongh-94673: Hide Objects in PyTypeObject Behind Accessors (pythongh-104074) pythongh-94673: Properly Initialize and Finalize Static Builtin Types for Each Interpreter (pythongh-104072) pythongh-104016: Skip test for deeply neste f-strings on wasi (python#104071)
carljm added a commit to carljm/cpython that referenced this pull request May 2, 2023
Merge branch 'main' into cached_property_docs …
b9c39e3
* main: (760 commits) pythonGH-104102: Optimize `pathlib.Path.glob()` handling of `../` pattern segments (pythonGH-104103) pythonGH-104104: Optimize `pathlib.Path.glob()` by avoiding repeated calls to `os.path.normcase()` (pythonGH-104105) pythongh-103822: [Calendar] change return value to enum for day and month APIs (pythonGH-103827) pythongh-65022: Fix description of tuple return value in copyreg (python#103892) pythonGH-103525: Improve exception message from `pathlib.PurePath()` (pythonGH-103526) pythongh-84436: Add integration C API tests for immortal objects (pythongh-103962) pythongh-103743: Add PyUnstable_Object_GC_NewWithExtraData (pythonGH-103744) pythongh-102997: Update Windows installer to SQLite 3.41.2. (python#102999) pythonGH-103484: Fix redirected permanently URLs (python#104001) Improve assert_type phrasing (python#104081) pythongh-102997: Update macOS installer to SQLite 3.41.2. (pythonGH-102998) pythonGH-103472: close response in HTTPConnection._tunnel (python#103473) pythongh-88496: IDLE - fix another test on macOS (python#104075) pythongh-94673: Hide Objects in PyTypeObject Behind Accessors (pythongh-104074) pythongh-94673: Properly Initialize and Finalize Static Builtin Types for Each Interpreter (pythongh-104072) pythongh-104016: Skip test for deeply neste f-strings on wasi (python#104071) pythongh-104057: Fix direct invocation of test_super (python#104064) pythongh-87092: Expose assembler to unit tests (python#103988) pythongh-97696: asyncio eager tasks factory (python#102853) pythongh-84436: Immortalize in _PyStructSequence_InitBuiltinWithFlags() (pythongh-104054) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
chrstphrchvz chrstphrchvz left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

terryjreedy

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Footer

© 2026 GitHub, Inc.