← 返回首页
gh-103583: Add ref. dependency between multibytecodec modules by erlend-aasland · Pull Request #103589 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

gh-103583: Add ref. dependency between multibytecodec modules#103589

Merged
erlend-aasland merged 4 commits into
python:mainfrom
erlend-aasland:cjk-ref-dependency
Apr 19, 2023
Merged

gh-103583: Add ref. dependency between multibytecodec modules#103589
erlend-aasland merged 4 commits into
python:mainfrom
erlend-aasland:cjk-ref-dependency

Conversation

erlend-aasland commented Apr 17, 2023 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

The cjk codec modules now always outlive _multibytecodec

bedevere-bot mentioned this pull request Apr 17, 2023
Closed

erlend-aasland commented Apr 17, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Depends on:

erlend-aasland mentioned this pull request Apr 17, 2023
Merged

erlend-aasland commented Apr 17, 2023

Copy link
Copy Markdown
Contributor Author

For the record, PyMultibyteCodec_CAPSULE_NAME is not exposed through Python.h:

$ echo '#include "Python.h"' | gcc -E $(./python.exe ./python-config.py --includes) - | grep PyMultibyteCodec_CAPSULE_NAME $

corona10 added the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Apr 19, 2023

bedevere-bot commented Apr 19, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @corona10 for commit e376c47 🤖

If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again.

bedevere-bot removed the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Apr 19, 2023

corona10 commented Apr 19, 2023

Copy link
Copy Markdown
Member

@erlend-aasland Please rebase the PR, I will review the PR by tomorrow :)

erlend-aasland commented Apr 19, 2023

Copy link
Copy Markdown
Contributor Author

Thanks, I will :)

erlend-aasland commented Apr 19, 2023

Copy link
Copy Markdown
Contributor Author

Ref. leak bots passed all green. Pulling in main now.

erlend-aasland commented Apr 19, 2023

Copy link
Copy Markdown
Contributor Author

@corona10, ready for your second review :)

corona10 approved these changes Apr 19, 2023
View reviewed changes

corona10 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

lgtm, patch itself looks pretty straightforward :)

erlend-aasland merged commit a6b07b5 into python:main Apr 19, 2023
erlend-aasland deleted the cjk-ref-dependency branch April 19, 2023 16:02
carljm added a commit to carljm/cpython that referenced this pull request Apr 20, 2023
Merge branch 'main' into superopt …
5c0a21c
* main: (24 commits) pythongh-98040: Move the Single-Phase Init Tests Out of test_imp (pythongh-102561) pythongh-83861: Fix datetime.astimezone() method (pythonGH-101545) pythongh-102856: Clean some of the PEP 701 tokenizer implementation (python#103634) pythongh-102856: Skip test_mismatched_parens in WASI builds (python#103633) pythongh-102856: Initial implementation of PEP 701 (python#102855) pythongh-103583: Add ref. dependency between multibytecodec modules (python#103589) pythongh-83004: Harden msvcrt further (python#103420) pythonGH-88342: clarify that `asyncio.as_completed` accepts generators yielding tasks (python#103626) pythongh-102778: IDLE - make sys.last_exc available in Shell after traceback (python#103314) pythongh-103582: Remove last references to `argparse.REMAINDER` from docs (python#103586) pythongh-103583: Always pass multibyte codec structs as const (python#103588) pythongh-103617: Fix compiler warning in _iomodule.c (python#103618) pythongh-103596: [Enum] do not shadow mixed-in methods/attributes (pythonGH-103600) pythonGH-100530: Change the error message for non-class class patterns (pythonGH-103576) pythongh-95299: Remove lingering setuptools reference in installer scripts (pythonGH-103613) [Doc] Fix a typo in optparse.rst (python#103504) pythongh-101100: Fix broken reference `__format__` in `string.rst` (python#103531) pythongh-95299: Stop installing setuptools as a part of ensurepip and venv (python#101039) pythonGH-103484: Docs: add linkcheck allowed redirects entries for most cases (python#103569) pythongh-67230: update whatsnew note for csv changes (python#103598) ...
erlend-aasland mentioned this pull request Apr 26, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

corona10 corona10 approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Footer

© 2026 GitHub, Inc.