← 返回首页
gh-74690: Add more tests for runtime-checkable protocols by AlexWaygood · Pull Request #103347 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

gh-74690: Add more tests for runtime-checkable protocols#103347

Merged
AlexWaygood merged 1 commit into
python:mainfrom
AlexWaygood:more-runtime-protocol-tests
Apr 7, 2023
Merged

gh-74690: Add more tests for runtime-checkable protocols#103347
AlexWaygood merged 1 commit into
python:mainfrom
AlexWaygood:more-runtime-protocol-tests

Conversation

AlexWaygood commented Apr 7, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

This PR adds more tests for runtime-checkable protocols, ensuring various edge cases are covered. Some of the invariants I'm adding tests for would have been broken by some more hare-brained optimisations that we considered, but rejected, in #74690 and #103310.

AlexWaygood added tests Tests in the Lib/test dir skip news topic-typing needs backport to 3.11 only security fixes labels Apr 7, 2023
AlexWaygood requested a review from carljm April 7, 2023 13:42
bedevere-bot mentioned this pull request Apr 7, 2023
Closed
AlexWaygood merged commit 800382a into python:main Apr 7, 2023

miss-islington commented Apr 7, 2023

Copy link
Copy Markdown
Contributor

Thanks @AlexWaygood for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

AlexWaygood deleted the more-runtime-protocol-tests branch April 7, 2023 17:21
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 7, 2023
pythongh-74690: Add more tests for runtime-checkable protocols (pytho… …
ea8f5fe
…nGH-103347) (cherry picked from commit 800382a) Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>

bedevere-bot commented Apr 7, 2023

Copy link
Copy Markdown

GH-103350 is a backport of this pull request to the 3.11 branch.

bedevere-bot removed the needs backport to 3.11 only security fixes label Apr 7, 2023
miss-islington added a commit that referenced this pull request Apr 7, 2023
gh-74690: Add more tests for runtime-checkable protocols (GH-103347) …
1b1f016
(cherry picked from commit 800382a) Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
warsaw pushed a commit to warsaw/cpython that referenced this pull request Apr 11, 2023
pythongh-74690: Add more tests for runtime-checkable protocols (pytho… …
3874680
…n#103347)
AlexWaygood mentioned this pull request Apr 12, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

carljm carljm approved these changes
gvanrossum Awaiting requested review from gvanrossum
Fidget-Spinner Awaiting requested review from Fidget-Spinner
JelleZijlstra Awaiting requested review from JelleZijlstra JelleZijlstra is a code owner

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir topic-typing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Footer

© 2026 GitHub, Inc.