← 返回首页
gh-48330: address review comments to PR-12271 by giampaolo · Pull Request #103209 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

gh-48330: address review comments to PR-12271#103209

Merged
giampaolo merged 1 commit into
python:mainfrom
giampaolo:unittest-durations-review-comments
Apr 16, 2023
Merged

gh-48330: address review comments to PR-12271#103209
giampaolo merged 1 commit into
python:mainfrom
giampaolo:unittest-durations-review-comments

Conversation

giampaolo commented Apr 3, 2023 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

Addresses @gpshead's post-merge comments to PR #12271.

address review comments to PR-12271 …
dac648f
Signed-off-by: Giampaolo Rodola <g.rodola@gmail.com>
giampaolo requested a review from gpshead April 3, 2023 08:46
giampaolo mentioned this pull request Apr 3, 2023
Merged
hauntsaninja changed the title bpo-4080: address review comments to PR-12271 gh-48330: address review comments to PR-12271 Apr 12, 2023
bedevere-bot mentioned this pull request Apr 12, 2023
Closed
hauntsaninja approved these changes Apr 12, 2023
View reviewed changes

hauntsaninja left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

Thanks for following up on it!

giampaolo merged commit ff3303e into python:main Apr 16, 2023
giampaolo deleted the unittest-durations-review-comments branch April 16, 2023 22:19
carljm added a commit to carljm/cpython that referenced this pull request Apr 17, 2023
Merge branch 'main' into superopt …
5136459
* main: Remove `expert-*` from `project-updater` GH workflow (python#103579) pythongh-103583: Add codecs and maps to _codecs_* module state (python#103540) pythongh-48330: address review comments to PR-12271 (python#103209) pythongh-103527: Add multibytecodec.h as make dep for _codecs_* (python#103567) pythongh-103553: Improve `test_inspect`: add more assertions, remove unused (python#103554) pythonGH-103517: Improve tests for `pathlib.Path.walk()` (pythonGH-103518) pythongh-102114: Make dis print more concise tracebacks for syntax errors in str inputs (python#102115) pythonGH-78079: Fix UNC device path root normalization in pathlib (pythonGH-102003) pythongh-101517: Add regression test for a lineno bug in try/except* impacting pdb (python#103547) pythongh-103527: Add make deps for _codecs_* and _multibytecodec (python#103528) pythongh-103532: Fix reST syntax in NEWS entry (pythonGH-103544) pythongh-103532: Add NEWS entry (python#103542)
carljm added a commit to carljm/cpython that referenced this pull request Apr 17, 2023
Merge branch 'superopt' into superopt_spec …
079c65a
* superopt: update generated cases with new comment review comments Remove `expert-*` from `project-updater` GH workflow (python#103579) pythongh-103583: Add codecs and maps to _codecs_* module state (python#103540) pythongh-48330: address review comments to PR-12271 (python#103209) pythongh-103527: Add multibytecodec.h as make dep for _codecs_* (python#103567) pythongh-103553: Improve `test_inspect`: add more assertions, remove unused (python#103554) pythonGH-103517: Improve tests for `pathlib.Path.walk()` (pythonGH-103518) pythongh-102114: Make dis print more concise tracebacks for syntax errors in str inputs (python#102115) pythonGH-78079: Fix UNC device path root normalization in pathlib (pythonGH-102003) pythongh-101517: Add regression test for a lineno bug in try/except* impacting pdb (python#103547) pythongh-103527: Add make deps for _codecs_* and _multibytecodec (python#103528) pythongh-103532: Fix reST syntax in NEWS entry (pythonGH-103544) pythongh-103532: Add NEWS entry (python#103542)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

hauntsaninja hauntsaninja approved these changes
gpshead Awaiting requested review from gpshead

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Footer

© 2026 GitHub, Inc.