← 返回首页
gh-84436: Make Interned Strings Immortal by ericsnowcurrently · Pull Request #102887 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

gh-84436: Make Interned Strings Immortal#102887

Draft
ericsnowcurrently wants to merge 19 commits into
python:mainfrom
ericsnowcurrently:immortal-interned-strings
Draft

gh-84436: Make Interned Strings Immortal#102887
ericsnowcurrently wants to merge 19 commits into
python:mainfrom
ericsnowcurrently:immortal-interned-strings

Conversation

ericsnowcurrently commented Mar 21, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

This is a prerequisite for a per-interpreter GIL if the interned strings dict stays global (e.g. gh-102858).

(This is based on gh-102925. It also requires gh-19474.)

bedevere-bot mentioned this pull request Mar 21, 2023
Closed
ericsnowcurrently mentioned this pull request Mar 21, 2023
Closed

ericsnowcurrently commented Mar 21, 2023

Copy link
Copy Markdown
Member Author

CC @kumaraditya303

Factor out add_threadstate().
546b934
Add _PyThreadState_InitDetached().
0bcd136
Add _PyThreadState_ClearDetached().
35d5310
Add _PyRuntime.cached_objects.main_tstate.
cba9e34
Add _Py_AcquireGlobalObjectsState() and _Py_ReleaseGlobalObjectsState().
3b1bb8b
Add _Py_AddToGlobalDict().
eb42aa1
Drop _Py_AcquireGlobalObjectsState() and _Py_ReleaseGlobalObjectsStat… …
4e9da2d
…e().
Add acquire_global_objects_lock() and release_global_objects_lock().
6216207
Add some TODO comments.
3c007c0
Factor out store_interned().
7d95514
Store a thread state to use just for interned strings.
5c20b84
Always use the main interpreter when possibly resizing the interned d… …
a3ae02a
…ict.
Use _PyRuntime.cached_objects.main_tstate instead.
d5fbc37
Add _PyThreadState_IsBound() and _PyThreadState_Unbind().
459325f
Make sure the one-off tstate is bound before using it.
4f25244
Use _Py_AcquireGlobalObjectsState() in store_interned().
e68535a
Use _Py_AddToGlobalDict().
22753b3
ericsnowcurrently force-pushed the immortal-interned-strings branch from 13f3b8f to ca776b1 Compare March 22, 2023 18:25
ericsnowcurrently force-pushed the immortal-interned-strings branch from ca776b1 to 9b0dc99 Compare March 22, 2023 18:34

github-actions Bot commented Apr 12, 2026

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

github-actions Bot added the stale Stale PR or inactive for long period of time. label Apr 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ZeroIntensity Awaiting requested review from ZeroIntensity ZeroIntensity will be requested when the pull request is marked ready for review ZeroIntensity is a code owner
FFY00 Awaiting requested review from FFY00 FFY00 will be requested when the pull request is marked ready for review FFY00 is a code owner

Assignees

No one assigned

Labels

awaiting core review skip news stale Stale PR or inactive for long period of time.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Footer

© 2026 GitHub, Inc.