← 返回首页
gh-93649: Split exception tests from _testcapimodule.c by erlend-aasland · Pull Request #102173 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

gh-93649: Split exception tests from _testcapimodule.c#102173

Merged
miss-islington merged 4 commits into
python:mainfrom
erlend-aasland:split-testcapi/exceptions
Feb 23, 2023
Merged

gh-93649: Split exception tests from _testcapimodule.c#102173
miss-islington merged 4 commits into
python:mainfrom
erlend-aasland:split-testcapi/exceptions

Conversation

erlend-aasland commented Feb 23, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Automerge-Triggered-By: GH:erlend-aasland

bedevere-bot mentioned this pull request Feb 23, 2023
Open

erlend-aasland commented Feb 23, 2023

Copy link
Copy Markdown
Contributor Author

Rationale: make it easier to increase coverage of the C API for exception handling.

Regarding the Lib/test part: the _testcapi stuff is scattered across a lot of test files. Would it make sense to consolidate these (in a follow-up PR)?

iritkatriel commented Feb 23, 2023

Copy link
Copy Markdown
Member

Rationale: make it easier to increase coverage of the C API for exception handling.

Regarding the Lib/test part: the _testcapi stuff is scattered across a lot of test files. Would it make sense to consolidate these (in a follow-up PR)?

It depends, we'd need to see why it's scattered like that. Could be divided on some other criteria.

erlend-aasland requested a review from a team as a code owner February 23, 2023 13:35

miss-islington commented Feb 23, 2023

Copy link
Copy Markdown
Contributor

@erlend-aasland: Status check is done, and it's a failure or timed out ❌.

miss-islington commented Feb 23, 2023

Copy link
Copy Markdown
Contributor

@erlend-aasland: Status check is done, and it's a failure or timed out ❌.

miss-islington commented Feb 23, 2023

Copy link
Copy Markdown
Contributor

Status check is done, and it's a success ✅.

miss-islington merged commit efc985a into python:main Feb 23, 2023
erlend-aasland deleted the split-testcapi/exceptions branch February 23, 2023 17:12
JelleZijlstra pushed a commit to JelleZijlstra/cpython that referenced this pull request Sep 10, 2024
pythongh-93649: Split exception tests from _testcapimodule.c (pythonG… …
2131bed
…H-102173) Automerge-Triggered-By: GH:erlend-aasland
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

iritkatriel iritkatriel approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Footer

© 2026 GitHub, Inc.