← 返回首页
gh-91896: Deprecate collections.abc.ByteString by hauntsaninja · Pull Request #102096 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

gh-91896: Deprecate collections.abc.ByteString#102096

Merged
JelleZijlstra merged 13 commits into
python:mainfrom
hauntsaninja:gh-91896
May 4, 2023
Merged

gh-91896: Deprecate collections.abc.ByteString#102096
JelleZijlstra merged 13 commits into
python:mainfrom
hauntsaninja:gh-91896

Conversation

hauntsaninja commented Feb 21, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Getting a DeprecationWarning on issubclass proved to be difficult, because it could affect unrelated looking things like isinstance(bytes, Sequence)

pythongh-91896: Deprecate collections.abc.ByteString …
804dfa1
Getting a DeprecationWarning on issubclass proved to be difficult, because it could affect unrelated looking things like `isinstance(bytes, Sequence)`
bedevere-bot mentioned this pull request Feb 21, 2023
Closed
AlexWaygood reviewed Feb 21, 2023
View reviewed changes

AlexWaygood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

Could you avoid the custom metaclass by using a combination of __init_subclass__ and __subclasshook__ instead?

hauntsaninja commented Feb 21, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Yeah, I started by trying to get that to work, but didn't see a way of making __subclasshook__ viable, since it would affect things like isinstance(bytes, Sequence) (it also has some other trickiness, e.g. I'd need to import warnings at collections.abc import time to silence the warning when we register / I think I'd need to make stacklevel configurable in warnings._deprecated to make it work?)

rhettinger removed their request for review February 21, 2023 16:28
hauntsaninja mentioned this pull request Feb 21, 2023
Closed
JelleZijlstra reviewed Feb 21, 2023
View reviewed changes

JelleZijlstra left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

Thanks!

It's unfortunate there's no warning on issubclass() but I don't have ideas for how to do that reliably either.

Comment thread Doc/library/collections.abc.rst Show resolved Hide resolved
JelleZijlstra reviewed Mar 9, 2023
View reviewed changes
Comment thread Lib/_collections_abc.py Show resolved Hide resolved
Comment thread Doc/library/collections.abc.rst Show resolved Hide resolved
hugovk reviewed Mar 9, 2023
View reviewed changes
Comment thread Doc/library/collections.abc.rst Outdated Show resolved Hide resolved
sobolevn reviewed Mar 11, 2023
View reviewed changes

sobolevn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

Glad to see it deprecated!

Comment thread Lib/_collections_abc.py Show resolved Hide resolved
sobolevn reviewed Mar 26, 2023
View reviewed changes
Comment thread Lib/_collections_abc.py
class ByteString(Sequence, metaclass=_DeprecateByteStringMeta):
"""This unifies bytes and bytearray.

XXX Should add all their methods.

sobolevn Mar 26, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

You can also remove this comment.

hugovk reviewed May 2, 2023
View reviewed changes
Comment thread Doc/whatsnew/3.12.rst Show resolved Hide resolved
Comment thread Misc/NEWS.d/next/Library/2023-03-08-02-45-46.gh-issue-91896.kgON_a.rst Show resolved Hide resolved
JelleZijlstra merged commit 09b7695 into python:main May 4, 2023
carljm added a commit to carljm/cpython that referenced this pull request May 5, 2023
Merge branch 'main' into inlinecomp2 …
8a78a36
* main: (61 commits) pythongh-64595: Argument Clinic: Touch source file if any output file changed (python#104152) pythongh-64631: Test exception messages in cloned Argument Clinic funcs (python#104167) pythongh-68395: Avoid naming conflicts by mangling variable names in Argument Clinic (python#104065) pythongh-64658: Expand Argument Clinic return converter docs (python#104175) pythonGH-103092: port `_asyncio` freelist to module state (python#104196) pythongh-104051: fix crash in test_xxtestfuzz with -We (python#104052) pythongh-104190: fix ubsan crash (python#104191) pythongh-104106: Add gcc fallback of mkfifoat/mknodat for macOS (pythongh-104129) pythonGH-104142: Fix _Py_RefcntAdd to respect immortality (pythonGH-104143) pythongh-104112: link from cached_property docs to method-caching FAQ (python#104113) pythongh-68968: Correcting message display issue with assertEqual (python#103937) pythonGH-103899: Provide a hint when accidentally calling a module (pythonGH-103900) pythongh-103963: fix 'make regen-opcode' in out-of-tree builds (python#104177) pythongh-102500: Add PEP 688 and 698 to the 3.12 release highlights (python#104174) pythonGH-81079: Add case_sensitive argument to `pathlib.Path.glob()` (pythonGH-102710) pythongh-91896: Deprecate collections.abc.ByteString (python#102096) pythongh-99593: Add tests for Unicode C API (part 2) (python#99868) pythongh-102500: Document PEP 688 (python#102571) pythongh-102500: Implement PEP 688 (python#102521) pythongh-96534: socketmodule: support FreeBSD divert(4) socket (python#96536) ...
hauntsaninja deleted the gh-91896 branch May 8, 2023 00:40
AlexWaygood mentioned this pull request May 8, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

hugovk hugovk left review comments
sobolevn sobolevn left review comments
AlexWaygood AlexWaygood left review comments
JelleZijlstra JelleZijlstra approved these changes
gvanrossum Awaiting requested review from gvanrossum
Fidget-Spinner Awaiting requested review from Fidget-Spinner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Footer

© 2026 GitHub, Inc.